linux-kernel - [jsarha:backport/cros-v4.14-intel-audio 5196/9999] include/drm/drm_print.h:217:2: error: this statement may fall through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 15 Apr 2022 13:30:17 +0800
From:   kernel test robot <lkp@...el.com>
To:     Haneen Mohammed <hamohammed.sa@...il.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Sean Paul <seanpaul@...omium.org>,
        Dominik Behr <dbehr@...omium.org>,
        Stéphane Marchesin <marcheu@...omium.org>
Subject: [jsarha:backport/cros-v4.14-intel-audio 5196/9999]
 include/drm/drm_print.h:217:2: error: this statement may fall through

Hi Haneen,

FYI, the error/warning still remains.

tree:   https://github.com/jsarha/linux backport/cros-v4.14-intel-audio
head:   ed5b3159902598be61b23ef22a235d9b1eaa9ad8
commit: 27e31e8e0e7a44982813ec603246138eee221bd4 [5196/9999] BACKPORT: drm: Move debug macros out of drmP.h
config: i386-randconfig-a011-20220411 (https://download.01.org/0day-ci/archive/20220415/202204151349.1jkLAiYB-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build):
        # https://github.com/jsarha/linux/commit/27e31e8e0e7a44982813ec603246138eee221bd4
        git remote add jsarha https://github.com/jsarha/linux
        git fetch --no-tags jsarha backport/cros-v4.14-intel-audio
        git checkout 27e31e8e0e7a44982813ec603246138eee221bd4
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/i915/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/drm/drm_mm.h:49:0,
                    from include/drm/drmP.h:73,
                    from drivers/gpu/drm/i915/i915_drv.h:47,
                    from drivers/gpu/drm/i915/intel_drv.h:33,
                    from drivers/gpu/drm/i915/intel_cdclk.c:24:
   drivers/gpu/drm/i915/intel_cdclk.c: In function 'pnv_get_cdclk':
>> include/drm/drm_print.h:217:2: error: this statement may fall through [-Werror=implicit-fallthrough=]
     drm_printk(KERN_ERR, DRM_UT_NONE, fmt, ##__VA_ARGS__)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/i915/intel_cdclk.c:318:3: note: in expansion of macro 'DRM_ERROR'
      DRM_ERROR("Unknown pnv display core clock 0x%04x\n", gcfgc);
      ^~~~~~~~~
   drivers/gpu/drm/i915/intel_cdclk.c:319:2: note: here
     case GC_DISPLAY_CLOCK_133_MHZ_PNV:
     ^~~~
   cc1: all warnings being treated as errors


vim +217 include/drm/drm_print.h

   186	
   187	#define _DRM_PRINTK(once, level, fmt, ...)				\
   188		do {								\
   189			printk##once(KERN_##level "[" DRM_NAME "] " fmt,	\
   190				     ##__VA_ARGS__);				\
   191		} while (0)
   192	
   193	#define DRM_INFO(fmt, ...)						\
   194		_DRM_PRINTK(, INFO, fmt, ##__VA_ARGS__)
   195	#define DRM_NOTE(fmt, ...)						\
   196		_DRM_PRINTK(, NOTICE, fmt, ##__VA_ARGS__)
   197	#define DRM_WARN(fmt, ...)						\
   198		_DRM_PRINTK(, WARNING, fmt, ##__VA_ARGS__)
   199	
   200	#define DRM_INFO_ONCE(fmt, ...)						\
   201		_DRM_PRINTK(_once, INFO, fmt, ##__VA_ARGS__)
   202	#define DRM_NOTE_ONCE(fmt, ...)						\
   203		_DRM_PRINTK(_once, NOTICE, fmt, ##__VA_ARGS__)
   204	#define DRM_WARN_ONCE(fmt, ...)						\
   205		_DRM_PRINTK(_once, WARNING, fmt, ##__VA_ARGS__)
   206	
   207	/**
   208	 * Error output.
   209	 *
   210	 * \param fmt printf() like format string.
   211	 * \param arg arguments
   212	 */
   213	#define DRM_DEV_ERROR(dev, fmt, ...)					\
   214		drm_dev_printk(dev, KERN_ERR, DRM_UT_NONE, __func__, " *ERROR*",\
   215			       fmt, ##__VA_ARGS__)
   216	#define DRM_ERROR(fmt, ...)						\
 > 217		drm_printk(KERN_ERR, DRM_UT_NONE, fmt,	##__VA_ARGS__)
   218	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp