linux-kernel - Re: [PATCH] misc: atmel-ssc: fix error check return value of platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <413afa94-5b9c-02e5-a735-db1b26f06722@microchip.com>
Date:   Fri, 15 Apr 2022 06:47:26 +0000
From:   <Codrin.Ciubotariu@...rochip.com>
To:     <cgel.zte@...il.com>
CC:     <arnd@...db.de>, <Nicolas.Ferre@...rochip.com>,
        <alexandre.belloni@...tlin.com>, <Claudiu.Beznea@...rochip.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <lv.ruyi@....com.cn>,
        <zealci@....com.cn>
Subject: Re: [PATCH] misc: atmel-ssc: fix error check return value of
 platform_get_irq()

On 13.04.2022 12:32, cgel.zte@...il.com wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> From: Lv Ruyi <lv.ruyi@....com.cn>
> 
> platform_get_irq() return negative value on failure, so null check of
> ssc->irq is incorrect. Fix it by comparing whether it is less than zero.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@....com.cn>

Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>

Thanks!