linux-kernel - Re: [PATCH v7 00/70] Introducing the Maple Tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 15 Apr 2022 01:11:05 -0600
From:   Yu Zhao <yuzhao@...gle.com>
To:     Andrew Morton <akpm@...ux-foundation.org>,
        Liam Howlett <liam.howlett@...cle.com>
Cc:     "maple-tree@...ts.infradead.org" <maple-tree@...ts.infradead.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 00/70] Introducing the Maple Tree

On Thu, Apr 14, 2022 at 12:19:11PM -0700, Andrew Morton wrote:
> On Thu, 14 Apr 2022 17:15:26 +0000 Liam Howlett <liam.howlett@...cle.com> wrote:
> 
> > > Also I noticed, for the end address to walk_page_range(), Matthew used
> > > -1 and you used ULONG_MAX in the maple branch; Andrew used TASK_SIZE
> > > below. Having a single value throughout would be great.
> > 
> > I think ULONG_MAX would be best, we should probably change the below to
> > ULONG_MAX.
> 
> I switched it to ULONG_MAX/
> 
> > I don't see the code below in mglru-mapletree (62dd11ea8d).  Am I on the
> > right branch/commit?
> 
> oop, sorry, sleepy guy failed to include all the mglru patches!  It
> should be fixed now (4e03b8e70232).

Hi Liam,

Mind taking a look? Thanks.

I used
  1fe4e0d45c05 (HEAD) mm/vmscan: remove obsolete comment in get_scan_count

On aarch64:
  arch/arm64/kernel/elfcore.c:120:2: error: no member named 'mmap' in 'struct mm_struct'
  arch/arm64/kernel/elfcore.c:120:2: error: no member named 'vm_next' in 'struct vm_area_struct'
  arch/arm64/kernel/elfcore.c:130:2: error: no member named 'mmap' in 'struct mm_struct'
  arch/arm64/kernel/elfcore.c:130:2: error: no member named 'vm_next' in 'struct vm_area_struct'
  arch/arm64/kernel/elfcore.c:13:23: note: expanded from macro 'for_each_mte_vma'
  arch/arm64/kernel/elfcore.c:13:45: note: expanded from macro 'for_each_mte_vma'
  arch/arm64/kernel/elfcore.c:85:2: error: no member named 'mmap' in 'struct mm_struct'
  arch/arm64/kernel/elfcore.c:85:2: error: no member named 'vm_next' in 'struct vm_area_struct'
  arch/arm64/kernel/elfcore.c:95:2: error: no member named 'mmap' in 'struct mm_struct'
  arch/arm64/kernel/elfcore.c:95:2: error: no member named 'vm_next' in 'struct vm_area_struct'

On x86_64:
  watchdog: BUG: soft lockup - CPU#63 stuck for 18537s! [stress-ng-madvi:34799]
  RIP: 0010:mas_start+0x79/0xe0
  Code: ff ff ff ff e8 38 c4 5f 00 85 c0 75 09 e8 3f 0b ad ff 85 c0 74 23 49 81 fe 01 10 00 00 72 4d 44 89 f0 83 e0 03 83 f8 02 75 42 <49> 83 e6 fd 4c 89 73 18 31 c0 5b 41 5e 5d c3 e8 23 c7 5f 00 85 c0
  RSP: 0018:ffffa2ea6e04fd28 EFLAGS: 00000246
  RAX: 0000000000000002 RBX: ffffa2ea6e04fd60 RCX: 9c6e876c4d865e00
  RDX: ffffa2ea6e04fe08 RSI: 00000000ffffffff RDI: ffff95cab6754a58
  RBP: ffffa2ea6e04fd38 R08: 0000000000000002 R09: 0000000000000000
  R10: 0000000000000000 R11: ffffffffffffffff R12: 0000000000000000
  R13: 0000000000000000 R14: ffff9609a44ecf1e R15: ffffa2ea6e04fd60
  FS:  0000000001cf6340(0000) GS:ffff96483fac0000(0000) knlGS:0000000000000000
  CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
  CR2: 0000000001cfca68 CR3: 0000000243f1a002 CR4: 00000000001706e0
  Call Trace:
   <TASK>
   mas_walk+0x2a/0x80
   find_vma_prev+0x69/0xc0
   do_madvise+0x14e/0x870
   ? __vm_munmap+0x101/0x180
   ? rcu_read_lock_sched_held+0x20/0xa0
   ? syscall_enter_from_user_mode+0x26/0x170
   ? trace_hardirqs_on+0x4e/0x60
   __x64_sys_madvise+0x29/0x30
   do_syscall_64+0x44/0xa0
   entry_SYSCALL_64_after_hwframe+0x44/0xae
  RIP: 0033:0x589927

  (stress-ng --class vm -a 20 -t 600s -temp-path /tmpdir/)
  (.config attached)

View attachment ".config" of type "text/plain" (139789 bytes)