linux-kernel - Re: [PATCH] char: tpm: Prepare cleanup of powerpc's asm/prom.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c30543a2-b1dc-4e83-489e-0f8cad34a3ae@csgroup.eu>
Date:   Fri, 15 Apr 2022 08:44:35 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Jarkko Sakkinen <jarkko@...nel.org>
CC:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Peter Huewe <peterhuewe@....de>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] char: tpm: Prepare cleanup of powerpc's asm/prom.h



Le 03/04/2022 à 12:23, Jarkko Sakkinen a écrit :
> On Sat, Apr 02, 2022 at 12:29:19PM +0200, Christophe Leroy wrote:
>> powerpc's asm/prom.h brings some headers that it doesn't
>> need itself.
>>
>> In order to clean it up, first add missing headers in
>> users of asm/prom.h
>>
>> Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>
> 
> I don't understand this. It changes nothing as far as kernel is concerned.


I sent v2 with a more detailed description.

Thanks
Christophe


> 
>> ---
>>   drivers/char/tpm/tpm_atmel.h   | 2 --
>>   drivers/char/tpm/tpm_ibmvtpm.c | 1 -
>>   2 files changed, 3 deletions(-)
>>
>> diff --git a/drivers/char/tpm/tpm_atmel.h b/drivers/char/tpm/tpm_atmel.h
>> index ba37e77e8af3..959f7cce8301 100644
>> --- a/drivers/char/tpm/tpm_atmel.h
>> +++ b/drivers/char/tpm/tpm_atmel.h
>> @@ -26,8 +26,6 @@ struct tpm_atmel_priv {
>>   
>>   #ifdef CONFIG_PPC64
>>   
>> -#include <asm/prom.h>
>> -
>>   #define atmel_getb(priv, offset) readb(priv->iobase + offset)
>>   #define atmel_putb(val, priv, offset) writeb(val, priv->iobase + offset)
>>   #define atmel_request_region request_mem_region
>> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
>> index 3af4c07a9342..1180cce7067a 100644
>> --- a/drivers/char/tpm/tpm_ibmvtpm.c
>> +++ b/drivers/char/tpm/tpm_ibmvtpm.c
>> @@ -20,7 +20,6 @@
>>   #include <linux/spinlock.h>
>>   #include <linux/interrupt.h>
>>   #include <linux/wait.h>
>> -#include <asm/prom.h>
>>   
>>   #include "tpm.h"
>>   #include "tpm_ibmvtpm.h"
>> -- 
>> 2.35.1
>>
> 
> BR, Jarkko