linux-kernel - Re: hwrng: mpfs

Open Source and information security mailing list archives

Message-ID: <d304baf7-7c7a-8e8f-10a2-b6c6144a2fd8@microchip.com>
Date:   Fri, 15 Apr 2022 10:20:33 +0000
From:   <Conor.Dooley@...rochip.com>
To:     <herbert@...dor.apana.org.au>
CC:     <linux-kernel@...r.kernel.org>, <linux-crypto@...r.kernel.org>,
        <linux-riscv@...ts.infradead.org>
Subject: Re: hwrng: mpfs - Enable COMPILE_TEST

On 15/04/2022 10:18, Conor.Dooley@...rochip.com wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On 15/04/2022 08:37, Herbert Xu wrote:
>> The dependency on HW_RANDOM is redundant so this patch removes it.
>> As this driver seems to cross-compile just fine we could also enable
>> COMPILE_TEST.
> 
> Sorry about that. Compile test makes sense to me too.
> 
> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com
woops, missing a >.

Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

> 
> Thanks for applying my patch :)
> Conor
> 
>>
>> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
>>
>> diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
>> index 18aa97974b8b..dad084c0ecee 100644
>> --- a/drivers/char/hw_random/Kconfig
>> +++ b/drivers/char/hw_random/Kconfig
>> @@ -387,7 +387,7 @@ config HW_RANDOM_PIC32
>>
>>    config HW_RANDOM_POLARFIRE_SOC
>>        tristate "Microchip PolarFire SoC Random Number Generator support"
>> -     depends on HW_RANDOM && POLARFIRE_SOC_SYS_CTRL
>> +     depends on POLARFIRE_SOC_SYS_CTRL || COMPILE_TEST
>>        help
>>          This driver provides kernel-side support for the Random Number
>>          Generator hardware found on PolarFire SoC (MPFS).
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives