linux-kernel - Re: [PATCH 00/11] smp: cross CPU call interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YllhUx6g7ySAtk9k@hirez.programming.kicks-ass.net>
Date:   Fri, 15 Apr 2022 14:13:07 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Donghai Qiao <dqiao@...hat.com>
Cc:     akpm@...ux-foundation.org, sfr@...b.auug.org.au, arnd@...db.de,
        heying24@...wei.com, andriy.shevchenko@...ux.intel.com,
        axboe@...nel.dk, rdunlap@...radead.org, tglx@...utronix.de,
        gor@...ux.ibm.com, donghai.w.qiao@...il.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/11] smp: cross CPU call interface

On Thu, Apr 14, 2022 at 10:46:50PM -0400, Donghai Qiao wrote:
> The motivation of submitting this patch set is intended to make the
> existing cross CPU call mechanism become a bit more formal interface
> and more friendly to the kernel developers.
> 
> Basically the minimum set of functions below can satisfy any demand
> for cross CPU call from kernel consumers. For the sack of simplicity
> self-explanatory and less code redundancy no ambiguity, the functions
> in this interface are renamed, simplified, or eliminated. But they
> are still inheriting the same semantics and parameter lists from their
> previous version.
> 
> int smp_xcall(int cpu, smp_call_func_t func, void *info, unsigned int flags)
> 
> int smp_xcall_cond(int cpu, smp_call_func_t func, void *info,
>                    smp_cond_func_t condf, unsigned int flags)
> 
> void smp_xcall_mask(const struct cpumask *mask, smp_call_func_t func,
>                     void *info, unsigned int flags)
> 
> void smp_xcall_mask_cond(const struct cpumask *mask, smp_call_func_t func,
>                          void *info, smp_cond_func_t condf, unsigned int flags)
> 
> int smp_xcall_private(int cpu, call_single_data_t *csd, unsigned int flags)
> 
> int smp_xcall_any(const struct cpumask *mask, smp_call_func_t func,
>                   void *info, unsigned int flags)
> 

Can we please remove that x? That's going to be horrible pain for a long
time to come.