linux-kernel - Re: [PATCH v3 3/3] fat: report creation time in statx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h76utrj2.fsf@mail.parknet.co.jp>
Date:   Fri, 15 Apr 2022 22:17:21 +0900
From:   OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:     Chung-Chiang Cheng <cccheng@...ology.com>
Cc:     linux-kernel@...r.kernel.org, kernel@...heng.net,
        shepjeng@...il.com
Subject: Re: [PATCH v3 3/3] fat: report creation time in statx

Chung-Chiang Cheng <cccheng@...ology.com> writes:

> @@ -568,10 +568,14 @@ int fat_fill_inode(struct inode *inode, struct msdos_dir_entry *de)
>  
>  	fat_time_fat2unix(sbi, &inode->i_mtime, de->time, de->date, 0);
>  	inode->i_ctime = inode->i_mtime;
> -	if (sbi->options.isvfat)
> +	if (sbi->options.isvfat) {
>  		fat_time_fat2unix(sbi, &inode->i_atime, 0, de->adate, 0);
> -	else
> +		fat_time_fat2unix(sbi, &MSDOS_I(inode)->i_crtime, de->ctime,
> +				  de->cdate, de->ctime_cs);
> +	} else {
>  		fat_truncate_atime(sbi, &inode->i_mtime, &inode->i_atime);
> +		fat_truncate_crtime(sbi, &inode->i_mtime, &MSDOS_I(inode)->i_crtime);
> +	}

Probably, nothing worth to update i_crtime here, right?

Thanks.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>