linux-kernel - Re: [PATCH] iio: gp2ap020a00f: Fix signedness bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <413b9d1c-922e-43cf-b864-52b73622a53d@meizu.com>
Date:   Fri, 15 Apr 2022 09:21:17 +0800
From:   baihaowen <baihaowen@...zu.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: gp2ap020a00f: Fix signedness bug

在 4/14/22 9:47 PM, Andy Shevchenko 写道:
> On Thu, Apr 14, 2022 at 2:19 PM Haowen Bai <baihaowen@...zu.com> wrote:
>> function gp2ap020a00f_get_thresh_reg() is unsigned but returning -EINVAL
>> errcode, and thresh_reg_l is unsigned but receiving -EINVAL errcode. so
>> we have to change u8 -> s8.
> s8 is not enough to hold an (arbitrary) error code. To be on the safe
> side you need to use int.
>
Thank you for your suggestion.

-- 
Haowen Bai