linux-kernel - Re: [PATCH v3 3/3] MIPS: Ingenic: Refresh USB nodes to match driver changes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <WBZDAR.1ZU7BOCJE9S11@crapouillou.net>
Date:   Fri, 15 Apr 2022 16:07:08 +0100
From:   Paul Cercueil <paul@...pouillou.net>
To:     周琰杰 <zhouyanjie@...yeetech.com>
Cc:     gregkh@...uxfoundation.org, hminas@...opsys.com,
        robh+dt@...nel.org, krzk+dt@...nel.org, tsbogend@...ha.franken.de,
        linux-usb@...r.kernel.org, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        dragancecavac@...oo.com, hns@...delico.com,
        dongsheng.qiu@...enic.com, aric.pzqi@...enic.com,
        rick.tyliu@...enic.com, sernia.zhou@...mail.com,
        zhenwenjin@...il.com, reimu@...omaker.com
Subject: Re: [PATCH v3 3/3] MIPS: Ingenic: Refresh USB nodes to match driver
 changes.

Hi Zhou,


Le ven., avril 15 2022 at 03:25:37 +0800, 周琰杰 (Zhou Yanjie) 
<zhouyanjie@...yeetech.com> a écrit :
> Refresh USB nodes in the jz4780.dtsi, x1000.dtsi, and x1830.dtsi 
> files.
> 
> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@...yeetech.com>
> ---
> 
> Notes:
>     v3:
>     New patch.
> 
>  arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 +-
>  arch/mips/boot/dts/ingenic/x1000.dtsi  | 2 +-
>  arch/mips/boot/dts/ingenic/x1830.dtsi  | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi 
> b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> index b998301..c182a65 100644
> --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
> +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> @@ -577,7 +577,7 @@
>  	};
> 
>  	otg: usb@...00000 {
> -		compatible = "ingenic,jz4780-otg", "snps,dwc2";
> +		compatible = "ingenic,jz4780-otg";

Could you refresh my memory - why are the "snps,dwc2" fallback strings 
removed?

To me it seems like they should be here, since the OTG IP in Ingenic 
SoCs is derived from the DWC2 IP.

Cheers,
-Paul

>  		reg = <0x13500000 0x40000>;
> 
>  		interrupt-parent = <&intc>;
> diff --git a/arch/mips/boot/dts/ingenic/x1000.dtsi 
> b/arch/mips/boot/dts/ingenic/x1000.dtsi
> index 8bd27ede..343818a2 100644
> --- a/arch/mips/boot/dts/ingenic/x1000.dtsi
> +++ b/arch/mips/boot/dts/ingenic/x1000.dtsi
> @@ -366,7 +366,7 @@
>  	};
> 
>  	otg: usb@...00000 {
> -		compatible = "ingenic,x1000-otg", "snps,dwc2";
> +		compatible = "ingenic,x1000-otg";
>  		reg = <0x13500000 0x40000>;
> 
>  		interrupt-parent = <&intc>;
> diff --git a/arch/mips/boot/dts/ingenic/x1830.dtsi 
> b/arch/mips/boot/dts/ingenic/x1830.dtsi
> index 2595df8..6aff19f 100644
> --- a/arch/mips/boot/dts/ingenic/x1830.dtsi
> +++ b/arch/mips/boot/dts/ingenic/x1830.dtsi
> @@ -355,7 +355,7 @@
>  	};
> 
>  	otg: usb@...00000 {
> -		compatible = "ingenic,x1830-otg", "snps,dwc2";
> +		compatible = "ingenic,x1830-otg";
>  		reg = <0x13500000 0x40000>;
> 
>  		interrupt-parent = <&intc>;
> --
> 2.7.4
>