linux-kernel - Re: [v4 13/14] iio: imu: add BNO055 I2C driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220415174938.51c81082@jic23-huawei>
Date:   Fri, 15 Apr 2022 17:49:38 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Andrea Merello <andrea.merello@...il.com>
Cc:     mchehab+huawei@...nel.org, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        lars@...afoo.de, robh+dt@...nel.org, andy.shevchenko@...il.com,
        matt.ranostay@...sulko.com, ardeleanalex@...il.com,
        jacopo@...ndi.org, Andrea Merello <andrea.merello@....it>
Subject: Re: [v4 13/14] iio: imu: add BNO055 I2C driver

On Fri, 15 Apr 2022 15:00:04 +0200
Andrea Merello <andrea.merello@...il.com> wrote:

> From: Andrea Merello <andrea.merello@....it>
> 
> This path adds an I2C driver for communicating to a BNO055 IMU via I2C
> bus and it enables the BNO055 core driver to work in this scenario.
> 
> Signed-off-by: Andrea Merello <andrea.merello@....it>
One trivial comment inline.

...
> diff --git a/drivers/iio/imu/bno055/Makefile b/drivers/iio/imu/bno055/Makefile
> index 20128b1a1afc..20f911aad94b 100644
> --- a/drivers/iio/imu/bno055/Makefile
> +++ b/drivers/iio/imu/bno055/Makefile
> @@ -2,5 +2,6 @@
>  
>  obj-$(CONFIG_BOSCH_BNO055_IIO) += bno055.o
>  obj-$(CONFIG_BOSCH_BNO055_SERIAL) += bno055_ser.o
> +obj-$(CONFIG_BOSCH_BNO055_I2C) += bno055_i2c.o
>  
>  CFLAGS_bno055_ser.o := -I$(src)
> diff --git a/drivers/iio/imu/bno055/bno055_i2c.c b/drivers/iio/imu/bno055/bno055_i2c.c
> new file mode 100644
> index 000000000000..d59bb4e661be
> --- /dev/null
> +++ b/drivers/iio/imu/bno055/bno055_i2c.c
> @@ -0,0 +1,56 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Support for I2C-interfaced Bosch BNO055 IMU.
> + *
> + * Copyright (C) 2021-2022 Istituto Italiano di Tecnologia
> + * Electronic Design Laboratory
> + * Written by Andrea Merello <andrea.merello@....it>
> + */
> +
> +#include <linux/i2c.h>
> +#include <linux/module.h>
Please add an include of
mod_devicetable.h for the struct of_device_id etc definitions

> +#include <linux/regmap.h>
> +
> +#include "bno055.h"
> +
> +#define BNO055_I2C_XFER_BURST_BREAK_THRESHOLD 3 /* FIXME */
> +
> +static int bno055_i2c_probe(struct i2c_client *client)
> +{
> +	struct regmap *regmap;
> +
> +	regmap = devm_regmap_init_i2c(client, &bno055_regmap_config);
> +	if (IS_ERR(regmap))
> +		return dev_err_probe(&client->dev, PTR_ERR(regmap),
> +				     "Unable to init register map");
> +
> +	return bno055_probe(&client->dev, regmap,
> +			    BNO055_I2C_XFER_BURST_BREAK_THRESHOLD, true);
> +}
> +
> +static const struct i2c_device_id bno055_i2c_id[] = {
> +	{"bno055", 0},
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(i2c, bno055_i2c_id);
> +
> +static const struct of_device_id __maybe_unused bno055_i2c_of_match[] = {
> +	{ .compatible = "bosch,bno055" },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(of, bno055_i2c_of_match);
> +
> +static struct i2c_driver bno055_driver = {
> +	.driver = {
> +		.name = "bno055-i2c",
> +		.of_match_table = of_match_ptr(bno055_i2c_of_match),
> +	},
> +	.probe_new = bno055_i2c_probe,
> +	.id_table = bno055_i2c_id,
> +};
> +module_i2c_driver(bno055_driver);
> +
> +MODULE_AUTHOR("Andrea Merello");
> +MODULE_DESCRIPTION("Bosch BNO055 I2C interface");
> +MODULE_IMPORT_NS(IIO_BNO055);
> +MODULE_LICENSE("GPL");