linux-kernel - Re: [PATCH v3 3/4] hugetlb: Fix return value of _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220415022408.6e6nqzvycf52n5yh@offworld>
Date:   Thu, 14 Apr 2022 19:24:08 -0700
From:   Davidlohr Bueso <dave@...olabs.net>
To:     Peng Liu <liupeng256@...wei.com>
Cc:     mike.kravetz@...cle.com, david@...hat.com,
        akpm@...ux-foundation.org, yaozhenguo1@...il.com,
        baolin.wang@...ux.alibaba.com, songmuchun@...edance.com,
        liuyuntao10@...wei.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/4] hugetlb: Fix return value of __setup handlers

On Wed, 13 Apr 2022, Peng Liu wrote:

>When __setup() return '0', using invalid option values causes the
>entire kernel boot option string to be reported as Unknown. Hugetlb
>calls __setup() and will return '0' when set invalid parameter
>string.
>
>The following phenomenon is observed:
> cmdline:
>  hugepagesz=1Y hugepages=1
> dmesg:
>  HugeTLB: unsupported hugepagesz=1Y
>  HugeTLB: hugepages=1 does not follow a valid hugepagesz, ignoring
>  Unknown kernel command line parameters "hugepagesz=1Y hugepages=1"
>
>Since hugetlb will print warning/error information before return for
>invalid parameter string, just use return '1' to avoid print again.
>
>Signed-off-by: Peng Liu <liupeng256@...wei.com>
>Reviewed-by: Baolin Wang <baolin.wang@...ux.alibaba.com>
>Reviewed-by: Muchun Song <songmuchun@...edance.com>
>Reviewed-by: Mike Kravetz <mike.kravetz@...cle.com>

Reviewed-by: Davidlohr Bueso <dave@...olabs.net>