linux-kernel - Re: [PATCH 2/2] dt-bindings: clock: ehrpwm: Add AM62 specific compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220415174000.cnnmolsaktl7ghye@jurist>
Date:   Fri, 15 Apr 2022 12:40:00 -0500
From:   Nishanth Menon <nm@...com>
To:     Georgi Vlaev <g-vlaev@...com>
CC:     <ssantosh@...nel.org>, <mturquette@...libre.com>,
        <sboyd@...nel.org>, <robh+dt@...nel.org>,
        <linux-kernel@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <devicetree@...r.kernel.org>, Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH 2/2] dt-bindings: clock: ehrpwm: Add AM62 specific
 compatible

On 16:41-20220415, Georgi Vlaev wrote:
> Introduce AM62 specific compatible for EPWM time-base
> sub-module clock. The time-base clock setup is identical
> to AM64. The only difference is AM62 provides 3 time-base
> clocks instead of the 9 found in AM64.
> 
> Signed-off-by: Georgi Vlaev <g-vlaev@...com>
> Tested-by: Vignesh Raghavendra <vigneshr@...com>

Reviewed-by: Nishanth Menon <nm@...com>


That said, please re-org the patches. Bindings come before the driver
changes :)

> ---
>  .../devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml         | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml b/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml
> index 9b537bc876b5..66765116aff5 100644
> --- a/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml
> +++ b/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml
> @@ -15,6 +15,7 @@ properties:
>        - enum:
>            - ti,am654-ehrpwm-tbclk
>            - ti,am64-epwm-tbclk
> +          - ti,am62-epwm-tbclk
>        - const: syscon
>  
>    "#clock-cells":
> -- 
> 2.30.2
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D