linux-kernel - Re: [PATCH v2 1/4] dt-bindings: pci: remove fallback from Rockchip DesignWare binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 15 Apr 2022 16:14:43 -0400
From:   Peter Geis <pgwipeout@...il.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Heiko Stuebner <heiko@...ech.de>,
        Shawn Lin <shawn.lin@...k-chips.com>,
        Simon Xue <xxm@...k-chips.com>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        PCI <linux-pci@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        arm-mail-list <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/4] dt-bindings: pci: remove fallback from Rockchip
 DesignWare binding

On Thu, Apr 14, 2022 at 1:53 PM Rob Herring <robh@...nel.org> wrote:
>
> On Wed, Apr 13, 2022 at 09:37:28AM -0400, Peter Geis wrote:
> > The snps,dw-pcie binds to a standalone driver.
> > It is not fully compatible with the Rockchip implementation and causes a
> > hang if it binds to the device.
> >
> > Remove this binding as a valid fallback.
> >
> > Signed-off-by: Peter Geis <pgwipeout@...il.com>
> > ---
> >  Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
> > index 142bbe577763..8dc11fed8a3c 100644
> > --- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
> > +++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml
> > @@ -32,7 +32,6 @@ properties:
> >    compatible:
> >      items:
> >        - const: rockchip,rk3568-pcie
> > -      - const: snps,dw-pcie
>
> With this, you no longer need 'select' so please drop it too.

Thanks! Will do.

>
> >
> >    reg:
> >      items:
> > @@ -110,7 +109,7 @@ examples:
> >          #size-cells = <2>;
> >
> >          pcie3x2: pcie@...80000 {
> > -            compatible = "rockchip,rk3568-pcie", "snps,dw-pcie";
> > +            compatible = "rockchip,rk3568-pcie";
> >              reg = <0x3 0xc0800000 0x0 0x390000>,
> >                    <0x0 0xfe280000 0x0 0x10000>,
> >                    <0x3 0x80000000 0x0 0x100000>;
> > --
> > 2.25.1
> >
> >