linux-kernel - Re: [PATCH] staging: qlge: add blank line after struct declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.22.394.2204160939110.3501@hadrien>
Date:   Sat, 16 Apr 2022 09:39:48 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Soumya Negi <soumya.negi97@...il.com>
cc:     Manish Chopra <manishc@...vell.com>, GR-Linux-NIC-Dev@...vell.com,
        Coiby Xu <coiby.xu@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        netdev@...r.kernel.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, outreachy@...ts.linux.dev
Subject: Re: [PATCH] staging: qlge: add blank line after struct declaration



On Fri, 15 Apr 2022, Soumya Negi wrote:

> Adhere to linux coding style. Reported by checkpatch:
> CHECK: Please use a blank line after function/struct/union/enum declarations

The subject line talks about a struct declaration, but there doesn't seem
to be one here.

julia

>
> Signed-off-by: Soumya Negi <soumya.negi97@...il.com>
> ---
>  drivers/staging/qlge/qlge.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h
> index 55e0ad759250..d0dd659834ee 100644
> --- a/drivers/staging/qlge/qlge.h
> +++ b/drivers/staging/qlge/qlge.h
> @@ -2072,6 +2072,7 @@ struct qlge_adapter *netdev_to_qdev(struct net_device *ndev)
>
>  	return ndev_priv->qdev;
>  }
> +
>  /*
>   * The main Adapter structure definition.
>   * This structure has all fields relevant to the hardware.
> --
> 2.17.1
>
>
>