[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75VfmJV4ON7r+cp+CrKrOgU99v=q0ZmrCV4jCC=Aj0q=pDw@mail.gmail.com>
Date: Sat, 16 Apr 2022 11:40:35 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Andrea Merello <andrea.merello@...il.com>
Cc: Jonathan Cameron <jic23@...nel.org>,
Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
linux-iio <linux-iio@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
devicetree <devicetree@...r.kernel.org>,
Lars-Peter Clausen <lars@...afoo.de>,
Rob Herring <robh+dt@...nel.org>,
Matt Ranostay <matt.ranostay@...sulko.com>,
Alexandru Ardelean <ardeleanalex@...il.com>,
jmondi <jacopo@...ndi.org>,
Andrea Merello <andrea.merello@....it>
Subject: Re: [v4 00/14] Add support for Bosch BNO055 IMU
On Fri, Apr 15, 2022 at 4:00 PM Andrea Merello <andrea.merello@...il.com> wrote:
>
> From: Andrea Merello <andrea.merello@....it>
>
> This series (tries to) add support for Bosch BNO055 IMU to Linux IIO
> subsystem. It is made up several patches:
>
> 1/13 to 7/12: add some IIO modifiers, and their documentation, to the IIO
> core layer, in order to being able to expose the linear
> acceleration and Euler angles among standard attributes.
> Also update the IIO event monitor tool
>
> 7/13: fix binary attributes didn't work with IIO
>
> 8/13 to 11/13: add the core IIO BNO055 driver and documentation for sysfs
> attributes and DT bindings
>
> 12/13: adds serdev BNO055 driver to actually use the IMU via serial line
>
> 13/13: adds I2C BNO055 driver to actually use the IMU via I2C wiring
>
> 14/13: add a documentation file that describe the bno055 driver and
> specifically the calibration
Thanks for a new version.
So far I have noticed the issues with more than one patch:
1) missed commit message;
2) non-imperative mode of speaking in the commit messages.
Please, take your time to refresh the Submitting Patches documentation
and fix your series accordingly.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists