linux-kernel - Re: [PATCH v1 1/1] iio: temperature: max31856: Make use of device properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220416115233.23625624@jic23-huawei>
Date:   Sat, 16 Apr 2022 11:52:33 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Lars-Peter Clausen <lars@...afoo.de>,
        Andrea Merello <andrea.merello@...il.com>,
        Paresh Chaudhary <paresh.chaudhary@...kwellcollins.com>
Subject: Re: [PATCH v1 1/1] iio: temperature: max31856: Make use of device
 properties

On Wed, 13 Apr 2022 21:50:44 +0300
Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> Convert the module to be property provider agnostic and allow
> it to be used on non-OF platforms.
> 
Added note on addition of mod_devicetable.h include.

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
+CC Andrea and Paresh

Seems straight forward so I've applied it but there is still time for
others to take a look.

Thanks,

Jonathan

> ---
>  drivers/iio/temperature/max31856.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/temperature/max31856.c b/drivers/iio/temperature/max31856.c
> index 54840881259a..8307aae2cb45 100644
> --- a/drivers/iio/temperature/max31856.c
> +++ b/drivers/iio/temperature/max31856.c
> @@ -7,9 +7,11 @@
>   */
>  
>  #include <linux/ctype.h>
> +#include <linux/mod_devicetable.h>
>  #include <linux/module.h>
>  #include <linux/init.h>
>  #include <linux/err.h>
> +#include <linux/property.h>
>  #include <linux/spi/spi.h>
>  #include <linux/iio/iio.h>
>  #include <linux/iio/sysfs.h>
> @@ -422,9 +424,7 @@ static int max31856_probe(struct spi_device *spi)
>  	indio_dev->channels = max31856_channels;
>  	indio_dev->num_channels = ARRAY_SIZE(max31856_channels);
>  
> -	ret = of_property_read_u32(spi->dev.of_node, "thermocouple-type",
> -				   &data->thermocouple_type);
> -
> +	ret = device_property_read_u32(&spi->dev, "thermocouple-type", &data->thermocouple_type);
>  	if (ret) {
>  		dev_info(&spi->dev,
>  			 "Could not read thermocouple type DT property, configuring as a K-Type\n");