linux-kernel - Re: [PATCH net-next v6] net/ipv6: Introduce accept_unsolicited_na knob to implement router-side changes for RFC9131

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOvjArRX_CXbUdAbfnta9sBad30aV0Q7HSA6rNPTKPbENRsnqQ@mail.gmail.com>
Date:   Sat, 16 Apr 2022 17:50:22 +0530
From:   Arun Ajith S <aajith@...sta.com>
To:     Bagas Sanjaya <bagasdotme@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
        David Ahern <dsahern@...nel.org>, yoshfuji@...ux-ipv6.org,
        kuba@...nel.org, pabeni@...hat.com, corbet@....net,
        prestwoj@...il.com, Bob Gilligan <gilligan@...sta.com>,
        Salam Noureddine <noureddine@...sta.com>,
        Gautam Kachroo <gk@...sta.com>
Subject: Re: [PATCH net-next v6] net/ipv6: Introduce accept_unsolicited_na
 knob to implement router-side changes for RFC9131

On Sat, Apr 16, 2022 at 11:13 AM Bagas Sanjaya <bagasdotme@...il.com> wrote:
>
> On 4/15/22 15:34, Arun Ajith S wrote:
> > +accept_unsolicited_na - BOOLEAN
> > +     Add a new neighbour cache entry in STALE state for routers on receiving an
> > +     unsolicited neighbour advertisement with target link-layer address option
> > +     specified. This is as per router-side behavior documented in RFC9131.
> > +     This has lower precedence than drop_unsolicited_na.
> > +
> > +      ====   ======  ======  ==============================================
> > +      drop   accept  fwding                   behaviour
> > +      ----   ------  ------  ----------------------------------------------
> > +         1        X       X  Drop NA packet and don't pass up the stack
> > +         0        0       X  Pass NA packet up the stack, don't update NC
> > +         0        1       0  Pass NA packet up the stack, don't update NC
> > +         0        1       1  Pass NA packet up the stack, and add a STALE
> > +                             NC entry
> > +      ====   ======  ======  ==============================================
> > +
> > +     This will optimize the return path for the initial off-link communication
> > +     that is initiated by a directly connected host, by ensuring that
> > +     the first-hop router which turns on this setting doesn't have to
> > +     buffer the initial return packets to do neighbour-solicitation.
> > +     The prerequisite is that the host is configured to send
> > +     unsolicited neighbour advertisements on interface bringup.
> > +     This setting should be used in conjunction with the ndisc_notify setting
> > +     on the host to satisfy this prerequisite.
> > +
> > +     By default this is turned off.
> > +
>
> Looks good. htmldocs builds successfully and the table displayed properly.
>
> Reviewed-by: Bagas Sanjaya <bagasdotme@...il.com>
>
> However, I remind you the following:
>
> - The patch changelogs should be put between the dashes (---) and diffstat.
>   I don't see the changelogs when I hit reply-all because you put them as
>   message signature (at very bottom of patch message).
> - DON'T DO top-posting, DO configure your MUA to make reply text below
>   the quoted text instead.
>
> --
> An old man doll... just what I always wanted! - Clara
Thank you.
I will keep the tips for the Changelog in my mind for my next patch.