linux-kernel - Re: [PATCH v2] fs: f2fs: remove WARN_ON in f2fs_is_valid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ec26e65f-5e5d-3c99-d631-148717333cf5@kernel.org>
Date:   Sat, 16 Apr 2022 10:29:39 +0800
From:   Chao Yu <chao@...nel.org>
To:     Dongliang Mu <dzm91@...t.edu.cn>, Jaegeuk Kim <jaegeuk@...nel.org>
Cc:     Dongliang Mu <mudongliangabcd@...il.com>,
        syzbot+763ae12a2ede1d99d4dc@...kaller.appspotmail.com,
        linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] fs: f2fs: remove WARN_ON in f2fs_is_valid_blkaddr



On 2022/4/15 21:19, Dongliang Mu wrote:
> From: Dongliang Mu <mudongliangabcd@...il.com>
> 
> Syzbot triggers two WARNs in f2fs_is_valid_blkaddr and
> __is_bitmap_valid. For example, in f2fs_is_valid_blkaddr,
> if type is DATA_GENERIC_ENHANCE or DATA_GENERIC_ENHANCE_READ,
> it invokes WARN_ON if blkaddr is not in the right range.
> The call trace is as follows:
> 
>   f2fs_get_node_info+0x45f/0x1070
>   read_node_page+0x577/0x1190
>   __get_node_page.part.0+0x9e/0x10e0
>   __get_node_page
>   f2fs_get_node_page+0x109/0x180
>   do_read_inode
>   f2fs_iget+0x2a5/0x58b0
>   f2fs_fill_super+0x3b39/0x7ca0
> 
> Fix these two WARNs by replacing WARN_ON with dump_stack.
> 
> Reported-by: syzbot+763ae12a2ede1d99d4dc@...kaller.appspotmail.com
> Signed-off-by: Dongliang Mu <mudongliangabcd@...il.com>

Reviewed-by: Chao Yu <chao@...nel.org>

Thanks,