[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d838c7f8-2d31-2327-9b4d-c05b06a516bb@linux.intel.com>
Date: Sat, 16 Apr 2022 08:04:42 +0800
From: Lu Baolu <baolu.lu@...ux.intel.com>
To: Robin Murphy <robin.murphy@....com>, joro@...tes.org,
will@...nel.org
Cc: baolu.lu@...ux.intel.com, iommu@...ts.linux-foundation.org,
sven@...npeter.dev, robdclark@...il.com, m.szyprowski@...sung.com,
yong.wu@...iatek.com, mjrosato@...ux.ibm.com,
gerald.schaefer@...ux.ibm.com, zhang.lyra@...il.com,
thierry.reding@...il.com, vdumpa@...dia.com,
jean-philippe@...aro.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/13] iommu: Move bus setup to IOMMU device registration
On 2022/4/14 20:42, Robin Murphy wrote:
> @@ -1883,27 +1900,12 @@ static int iommu_bus_init(struct bus_type *bus)
> */
> int bus_set_iommu(struct bus_type *bus, const struct iommu_ops *ops)
> {
> - int err;
> -
> - if (ops == NULL) {
> - bus->iommu_ops = NULL;
> - return 0;
> - }
> -
> - if (bus->iommu_ops != NULL)
> + if (bus->iommu_ops && ops && bus->iommu_ops != ops)
> return -EBUSY;
>
> bus->iommu_ops = ops;
Do we still need to keep above lines in bus_set_iommu()?
Best regards,
baolu
Powered by blists - more mailing lists