linux-kernel - [PATCH v1] checkpatch: Skip "From" tag from 75 character limit enforcement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat, 16 Apr 2022 03:43:50 +0000
From:   Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>
To:     Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>,
        Dwaipayan Ray <dwaipayanray1@...il.com>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     linux-kernel@...r.kernel.org,
        Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>
Subject: [PATCH v1] checkpatch: Skip "From" tag from 75 character limit enforcement

From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...el.com>

Currently, checkpatch script skips tags like "Fixes", "Link" and
"$signature_tags" when enforcing the 75 character limit in the commit
log. But it is missing the "From" tag in the skip list. So if a commit
log includes a "From:" tag with a long name or email, it reports a
false warning message.

To avoid this issue, include the "From" tag in the 75 character limit
enforcement skip list.

Reported-by: Dave Hansen <dave.hansen@...el.com>
Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...el.com>
---
 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 577e02998701..c8cbc216f098 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3174,7 +3174,7 @@ sub process {
 					# file delta changes
 		      $line =~ /^\s*(?:[\w\.\-\+]*\/)++[\w\.\-\+]+:/ ||
 					# filename then :
-		      $line =~ /^\s*(?:Fixes:|Link:|$signature_tags)/i ||
+		      $line =~ /^\s*(?:From:|Fixes:|Link:|$signature_tags)/i ||
 					# A Fixes: or Link: line or signature tag line
 		      $commit_log_possible_stack_dump)) {
 			WARN("COMMIT_LOG_LONG_LINE",
-- 
2.25.1