linux-kernel - Re: [PATCH 2/2] ARM: dts: keystone: fix case in SPI NOR node compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1cecb0c3-2925-765f-0654-37d5703b75b8@linaro.org>
Date:   Sun, 17 Apr 2022 19:58:01 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Nishanth Menon <nm@...com>
Cc:     Santosh Shilimkar <ssantosh@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: keystone: fix case in SPI NOR node
 compatible

On 15/04/2022 20:54, Nishanth Menon wrote:
> 
> I have no idea how this works. There is no documentation for the
> compatible, So I am guessing adding it to Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml 
> is appropriate prior to replacing  with "micron,n25q128a11", "jedec,spi-nor";

Compatible is documented in jedec,spi-nor.yaml (through pattern),
although it should be followed by "jedec,spi-nor", according to schema.
I did not fix that missing compatible fallback, because I did not want
to break any setup (I cannot test it), but adding the fallback seems
harmless/safe.
> 
> $ git grep micron,n25q128a11 .
> arch/arm/boot/dts/imx6qdl-aristainetos.dtsi:            compatible = "micron,n25q128a11", "jedec,spi-nor";
> arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi:           compatible = "micron,n25q128a11", "jedec,spi-nor";
> arch/arm/boot/dts/keystone-k2e-evm.dts:         compatible = "micron,n25q128a11";
> arch/arm/boot/dts/keystone-k2hk-evm.dts:                compatible = "micron,n25q128a11";
> arch/arm/boot/dts/keystone-k2l-evm.dts:         compatible = "micron,n25q128a11";
> arch/powerpc/boot/dts/fsl/t1024qds.dts:                         compatible = "micron,n25q128a11", "jedec,spi-nor";  /* 16MB */
> arch/powerpc/boot/dts/fsl/t104xqds.dtsi:                                compatible = "micron,n25q128a11", "jedec,spi-nor";
> arch/powerpc/boot/dts/fsl/t208xqds.dtsi:                                compatible = "micron,n25q128a11", "jedec,spi-nor"; /* 16MB */
> 
> 


Best regards,
Krzysztof