linux-kernel - Re: [PATCH] r8188eu: remove unused urbs from struct xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6c29201d-a717-9ce3-21c0-6c663fc9add3@gmail.com>
Date:   Sun, 17 Apr 2022 21:13:09 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     Ivan Safonov <insafonov@...il.com>,
        Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Michael Straube <straube.linux@...il.com>,
        "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        Martin Kaiser <martin@...ser.cx>,
        Cai Huoqing <cai.huoqing@...ux.dev>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] r8188eu: remove unused urbs from struct xmit_buf

Hi Ivan,

On 4/17/22 19:36, Ivan Safonov wrote:
> Driver allocates eighth urbs per xmit_buf, but uses only first urb.
> Allocation of seven remaining urbs wastes memory for nothing.
> 
> Signed-off-by: Ivan Safonov <insafonov@...il.com>

thanks,

Reviewed-by: Pavel Skripkin <paskripkin@...il.com>



With regards,
Pavel Skripkin

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)