linux-kernel - Re: [PATCH 1/2] dt-bindings: usb: tps6598x: Make the interrupts property optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56c72151-af5f-366b-b17f-24b9fb6264da@ti.com>
Date:   Mon, 18 Apr 2022 10:49:08 +0530
From:   Aswath Govindraju <a-govindraju@...com>
To:     Roger Quadros <rogerq@...nel.org>
CC:     Vignesh Raghavendra <vigneshr@...com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Sven Peter <sven@...npeter.dev>,
        Alyssa Rosenzweig <alyssa@...enzweig.io>,
        Hector Martin <marcan@...can.st>,
        Martin Kepplinger <martink@...teo.de>,
        "Bryan O'Donoghue" <bryan.odonoghue@...aro.org>,
        <linux-usb@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: usb: tps6598x: Make the interrupts
 property optional

Hi Roger,

On 14/04/22 23:40, Roger Quadros wrote:
> Hi,
> 
> On 14/04/2022 11:31, Aswath Govindraju wrote:
>> Support for polling has been added in the driver, which will be used by
>> default if interrupts property is not populated. Therefore, remove
>> interrupts and interrupt-names from the required properties and add a note
>> under interrupts property describing the above support in driver.
>>
>> Suggested-by: Roger Quadros <rogerq@...nel.org>
> 
> I did not suggest to make interrupts optional by default.
> 
> What I suggested was that if a DT property exists to explicitly
> indicate polling mode then interrupts are not required.
> 

ohh okay, got it. However, may I know if adding a dt property to
indicate polling for aiding the driver, is the correct approach to model it?

In terms of modelling hardware, as interrupts are not connected we are
not populating the interrupts property. Shouldn't that be all. If we are
adding a property explicitly to indicate polling that can be used by
driver, wouldn't that be a software aid being added in the device tree?

Thanks,
Aswath

>> Signed-off-by: Aswath Govindraju <a-govindraju@...com>
>> ---
>>  Documentation/devicetree/bindings/usb/ti,tps6598x.yaml | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
>> index a4c53b1f1af3..1c4b8c6233e5 100644
>> --- a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
>> +++ b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
>> @@ -25,6 +25,8 @@ properties:
>>  
>>    interrupts:
>>      maxItems: 1
>> +    description:
>> +      If interrupts are not populated then by default polling will be used.
>>  
>>    interrupt-names:
>>      items:
>> @@ -33,8 +35,6 @@ properties:
>>  required:
>>    - compatible
>>    - reg
>> -  - interrupts
>> -  - interrupt-names
>>  
>>  additionalProperties: true
>>  
> 
> cheers,
> -roger