[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Yl0ON+E7bYluGIYG@ravnborg.org>
Date: Mon, 18 Apr 2022 09:07:35 +0200
From: Sam Ravnborg <sam@...nborg.org>
To: Paul Cercueil <paul@...pouillou.net>
Cc: Thierry Reding <thierry.reding@...il.com>,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
Christophe Branchereau <cbranchereau@...il.com>,
kbuild-all <kbuild-all@...ts.01.org>,
Stephen Rothwell <sfr@...b.auug.org.au>,
kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] drm/panel: newvision-nv3052c: Fix build
On Sat, Apr 09, 2022 at 11:00:16AM +0100, Paul Cercueil wrote:
> The driver was compile-tested then rebased on drm-misc-next, and not
> compile-tested after the rebase; unfortunately the driver didn't compile
> anymore when it hit drm-misc-next.
>
> Fixes: 49956b505c53 ("drm/panel: Add panel driver for NewVision NV3052C based LCDs")
> Cc: Christophe Branchereau <cbranchereau@...il.com>
> Cc: kbuild-all <kbuild-all@...ts.01.org>
> Cc: Stephen Rothwell <sfr@...b.auug.org.au>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Paul Cercueil <paul@...pouillou.net>
Acked-by: Sam Ravnborg <sam@...nborg.org>
> ---
> drivers/gpu/drm/panel/panel-newvision-nv3052c.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
> index 127bcfdb59df..cf078f0d3cd3 100644
> --- a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
> +++ b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
> @@ -416,15 +416,13 @@ static int nv3052c_probe(struct spi_device *spi)
> return 0;
> }
>
> -static int nv3052c_remove(struct spi_device *spi)
> +static void nv3052c_remove(struct spi_device *spi)
> {
> struct nv3052c *priv = spi_get_drvdata(spi);
>
> drm_panel_remove(&priv->panel);
> drm_panel_disable(&priv->panel);
> drm_panel_unprepare(&priv->panel);
> -
> - return 0;
> }
>
> static const struct drm_display_mode ltk035c5444t_modes[] = {
> --
> 2.35.1
Powered by blists - more mailing lists