linux-kernel - Re: [PATCH] HID: nintendo: deregister home LED when it fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <39QNT1MSMJLC1.2M2V40UQZFSEE@homearch.localdomain>
Date:   Mon, 18 Apr 2022 16:17:11 +0200
From:   "Silvan Jegen" <s.jegen@...il.com>
To:     Icenowy Zheng <icenowy@...c.io>
Cc:     "Daniel J . Ogorchock" <djogorchock@...il.com>,
        Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: nintendo: deregister home LED when it fails

Hi

Icenowy Zheng <icenowy@...c.io> wrote:
> Some Pro Controller compatible controllers do not support home LED, and
> will fail when setting it. Currently this leads to probe failure.
> 
> Change the code that fails probing to deregistering home LED.
> 
> Signed-off-by: Icenowy Zheng <icenowy@...c.io>

Reviewed-by: Silvan Jegen <s.jegen@...il.com>

I don't have a "Nintendo Pro Controller"-compatible controller to test
with but I have compiled a Kernel with this patch applied and can confirm
that the original Nintendo Pro Controller is still probed correctly with
this patch applied.


Cheers,

Silvan