lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Mon, 18 Apr 2022 16:04:59 +0800
From:   kernel test robot <lkp@...el.com>
To:     Yury Norov <yury.norov@...il.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [norov:bitmap 44/47] include/linux/bitmap.h:270:44: warning: array
 subscript 'long unsigned int[10]' is partly outside array bounds of 'struct
 ethtool_link_usettings[1]'

tree:   https://github.com/norov/linux bitmap
head:   45a9e3feb171ccf077979b7ff6a0c6a732cfc17b
commit: 44fa42b086fd02ab7d41d92800b6888ee240fcdf [44/47] lib/bitmap: don't implement bitmap_(from,to)_arr32 on LE systems
config: alpha-defconfig (https://download.01.org/0day-ci/archive/20220418/202204181531.Chxo5619-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/norov/linux/commit/44fa42b086fd02ab7d41d92800b6888ee240fcdf
        git remote add norov https://github.com/norov/linux
        git fetch --no-tags norov bitmap
        git checkout 44fa42b086fd02ab7d41d92800b6888ee240fcdf
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash net/ethtool/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/cpumask.h:12,
                    from include/linux/smp.h:13,
                    from include/linux/lockdep.h:14,
                    from include/linux/spinlock.h:62,
                    from include/linux/ipc.h:5,
                    from include/uapi/linux/sem.h:5,
                    from include/linux/sem.h:5,
                    from include/linux/compat.h:14,
                    from net/ethtool/ioctl.c:10:
   net/ethtool/ioctl.c: In function 'store_link_ksettings_for_user.constprop':
>> include/linux/bitmap.h:270:44: warning: array subscript 'long unsigned int[10]' is partly outside array bounds of 'struct ethtool_link_usettings[1]' [-Warray-bounds]
     270 |                 dst[nbits / BITS_PER_LONG] &= BITMAP_LAST_WORD_MASK(nbits);
         |                                            ^~
   net/ethtool/ioctl.c:516:39: note: while referencing 'link_usettings'
     516 |         struct ethtool_link_usettings link_usettings;
         |                                       ^~~~~~~~~~~~~~
   In file included from include/linux/cpumask.h:12,
                    from include/linux/smp.h:13,
                    from include/linux/lockdep.h:14,
                    from include/linux/spinlock.h:62,
                    from include/linux/ipc.h:5,
                    from include/uapi/linux/sem.h:5,
                    from include/linux/sem.h:5,
                    from include/linux/compat.h:14,
                    from net/ethtool/ioctl.c:10:
>> include/linux/bitmap.h:270:44: warning: array subscript 'long unsigned int[10]' is partly outside array bounds of 'struct ethtool_link_usettings[1]' [-Warray-bounds]
     270 |                 dst[nbits / BITS_PER_LONG] &= BITMAP_LAST_WORD_MASK(nbits);
         |                                            ^
   net/ethtool/ioctl.c:516:39: note: while referencing 'link_usettings'
     516 |         struct ethtool_link_usettings link_usettings;
         |                                       ^~~~~~~~~~~~~~
   In file included from include/linux/string.h:20,
                    from include/linux/bitmap.h:11,
                    from include/linux/cpumask.h:12,
                    from include/linux/smp.h:13,
                    from include/linux/lockdep.h:14,
                    from include/linux/spinlock.h:62,
                    from include/linux/ipc.h:5,
                    from include/uapi/linux/sem.h:5,
                    from include/linux/sem.h:5,
                    from include/linux/compat.h:14,
                    from net/ethtool/ioctl.c:10:
   In function 'bitmap_copy',
       inlined from 'bitmap_copy_clear_tail' at include/linux/bitmap.h:268:2,
       inlined from 'store_link_ksettings_for_user.constprop' at net/ethtool/ioctl.c:525:2:
>> arch/alpha/include/asm/string.h:22:16: warning: '__builtin_memcpy' forming offset [84, 87] is out of the bounds [0, 84] of object 'link_usettings' with type 'struct ethtool_link_usettings' [-Warray-bounds]
      22 | #define memcpy __builtin_memcpy
   include/linux/bitmap.h:259:9: note: in expansion of macro 'memcpy'
     259 |         memcpy(dst, src, len);
         |         ^~~~~~
   net/ethtool/ioctl.c: In function 'store_link_ksettings_for_user.constprop':
   net/ethtool/ioctl.c:516:39: note: 'link_usettings' declared here
     516 |         struct ethtool_link_usettings link_usettings;
         |                                       ^~~~~~~~~~~~~~
   In file included from include/linux/string.h:20,
                    from include/linux/bitmap.h:11,
                    from include/linux/cpumask.h:12,
                    from include/linux/smp.h:13,
                    from include/linux/lockdep.h:14,
                    from include/linux/spinlock.h:62,
                    from include/linux/ipc.h:5,
                    from include/uapi/linux/sem.h:5,
                    from include/linux/sem.h:5,
                    from include/linux/compat.h:14,
                    from net/ethtool/ioctl.c:10:
   In function 'bitmap_copy',
       inlined from 'bitmap_copy_clear_tail' at include/linux/bitmap.h:268:2,
       inlined from 'load_link_ksettings_from_user' at net/ethtool/ioctl.c:483:2:
>> arch/alpha/include/asm/string.h:22:16: warning: '__builtin_memcpy' forming offset [84, 87] is out of the bounds [0, 84] of object 'link_usettings' with type 'struct ethtool_link_usettings' [-Warray-bounds]
      22 | #define memcpy __builtin_memcpy
   include/linux/bitmap.h:259:9: note: in expansion of macro 'memcpy'
     259 |         memcpy(dst, src, len);
         |         ^~~~~~
   net/ethtool/ioctl.c: In function 'load_link_ksettings_from_user':
   net/ethtool/ioctl.c:471:39: note: 'link_usettings' declared here
     471 |         struct ethtool_link_usettings link_usettings;
         |                                       ^~~~~~~~~~~~~~


vim +270 include/linux/bitmap.h

^1da177e4c3f41 Linus Torvalds 2005-04-16  261  
c724f193619c89 Yury Norov     2018-02-06  262  /*
c724f193619c89 Yury Norov     2018-02-06  263   * Copy bitmap and clear tail bits in last word.
c724f193619c89 Yury Norov     2018-02-06  264   */
c724f193619c89 Yury Norov     2018-02-06  265  static inline void bitmap_copy_clear_tail(unsigned long *dst,
c724f193619c89 Yury Norov     2018-02-06  266  		const unsigned long *src, unsigned int nbits)
c724f193619c89 Yury Norov     2018-02-06  267  {
c724f193619c89 Yury Norov     2018-02-06  268  	bitmap_copy(dst, src, nbits);
c724f193619c89 Yury Norov     2018-02-06  269  	if (nbits % BITS_PER_LONG)
c724f193619c89 Yury Norov     2018-02-06 @270  		dst[nbits / BITS_PER_LONG] &= BITMAP_LAST_WORD_MASK(nbits);
c724f193619c89 Yury Norov     2018-02-06  271  }
c724f193619c89 Yury Norov     2018-02-06  272  

:::::: The code at line 270 was first introduced by commit
:::::: c724f193619c896621bf5818d71ce77437f49a06 bitmap: new bitmap_copy_safe and bitmap_{from,to}_arr32

:::::: TO: Yury Norov <ynorov@...iumnetworks.com>
:::::: CC: Linus Torvalds <torvalds@...ux-foundation.org>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ