[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.22.394.2204181837420.13551@hadrien>
Date: Mon, 18 Apr 2022 18:37:53 +0200 (CEST)
From: Julia Lawall <julia.lawall@...ia.fr>
To: Aliya Rahmani <aliyarahmani786@...il.com>
cc: clabbe@...libre.com, gregkh@...uxfoundation.org,
linux-staging@...ts.linux.dev, outreachy@...ts.linux.dev,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] staging: media: zoran: else is not generally
useful after a break or return
On Mon, 18 Apr 2022, Aliya Rahmani wrote:
> Remove the else without affecting the logic. Fixes the checkpatch warning: else is not generally useful after a break or return
This line is still too long.
julia
>
> Signed-off-by: Aliya Rahmani <aliyarahmani786@...il.com>
> ---
> drivers/staging/media/zoran/videocodec.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/zoran/videocodec.c b/drivers/staging/media/zoran/videocodec.c
> index 16a1f23a7f19..19732a47c8bd 100644
> --- a/drivers/staging/media/zoran/videocodec.c
> +++ b/drivers/staging/media/zoran/videocodec.c
> @@ -98,9 +98,8 @@ struct videocodec *videocodec_attach(struct videocodec_master *master)
>
> h->attached += 1;
> return codec;
> - } else {
> - kfree(codec);
> }
> + kfree(codec);
> }
> h = h->next;
> }
> --
> 2.25.1
>
>
>
Powered by blists - more mailing lists