[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20220418164356.3532969-1-trix@redhat.com>
Date: Mon, 18 Apr 2022 12:43:56 -0400
From: Tom Rix <trix@...hat.com>
To: nsaenz@...nel.org, bcm-kernel-feedback-list@...adcom.com,
gregkh@...uxfoundation.org, stefan.wahren@...e.com,
gascoar@...il.com, ojaswin98@...il.com
Cc: linux-rpi-kernel@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org,
linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
Tom Rix <trix@...hat.com>
Subject: [PATCH] staging: vchiq_arm: change vchiq_platform_init from global to static
Smatch reports this issue
vchiq_arm.c:466:5: warning: symbol 'vchiq_platform_init'
was not declared. Should it be static?
vchiq_platform_init is only used in vchiq_arm.c. Single
file variables should not be global so change
vchiq_platform_init's storage-class specifier to static.
Signed-off-by: Tom Rix <trix@...hat.com>
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
index 0596ac61e286..7de98655e8ec 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
@@ -463,7 +463,7 @@ free_pagelist(struct vchiq_pagelist_info *pagelistinfo,
cleanup_pagelistinfo(pagelistinfo);
}
-int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state)
+static int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state)
{
struct device *dev = &pdev->dev;
struct vchiq_drvdata *drvdata = platform_get_drvdata(pdev);
--
2.27.0
Powered by blists - more mailing lists