linux-kernel - Re: [PATCH] s390: vfio-ap: Remove the superfluous MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yl2ZS7lyzyit9lbk@osiris>
Date:   Mon, 18 Apr 2022 19:00:59 +0200
From:   Heiko Carstens <hca@...ux.ibm.com>
To:     Tony Krowiak <akrowiak@...ux.ibm.com>
Cc:     Thomas Huth <thuth@...hat.com>, Halil Pasic <pasic@...ux.ibm.com>,
        Jason Herne <jjherne@...ux.ibm.com>,
        linux-s390@...r.kernel.org,
        Harald Freudenberger <freude@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] s390: vfio-ap: Remove the superfluous
 MODULE_DEVICE_TABLE declaration

On Mon, Apr 18, 2022 at 10:23:38AM -0400, Tony Krowiak wrote:
> Reviewed-by: Tony Krowiak <akrowiak@...ux.ibm.com>
> 
> On 4/13/22 5:44 AM, Thomas Huth wrote:
> > The vfio_ap module tries to register for the vfio_ap bus - but that's
> > the interface that it provides itself, so this does not make much sense,
> > thus let's simply drop this statement now.
> > 
> > Signed-off-by: Thomas Huth <thuth@...hat.com>
> > ---
> >   See also my previous patch to register it for the "ap" bus instead:
> >   https://lore.kernel.org/linux-s390/20211201141110.94636-1-thuth@redhat.com/
> >   ... but since it has been decided to not auto-load the module uncondi-
> >   tionally, I'd like to suggest to rather drop this line now instead.
> > 
> >   drivers/s390/crypto/vfio_ap_drv.c | 2 --
> >   1 file changed, 2 deletions(-)

...

Applied, thanks.