linux-kernel - Re: [PATCH 5.15 000/189] 5.15.35-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 18 Apr 2022 10:17:04 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Holger Hoffstätte <holger@...lied-asynchrony.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Cc:     stable@...r.kernel.org, torvalds@...ux-foundation.org,
        akpm@...ux-foundation.org, shuah@...nel.org, patches@...nelci.org,
        lkft-triage@...ts.linaro.org, pavel@...x.de, jonathanh@...dia.com,
        f.fainelli@...il.com, sudipm.mukherjee@...il.com,
        slade@...dewatkins.com,
        Nicholas Kazlauskas <nicholas.kazlauskas@....com>
Subject: Re: [PATCH 5.15 000/189] 5.15.35-rc1 review

On 4/18/22 09:49, Holger Hoffstätte wrote:
> On 2022-04-18 18:27, Guenter Roeck wrote:
>> On 4/18/22 07:07, Holger Hoffstätte wrote:
>>> On 2022-04-18 14:10, Greg Kroah-Hartman wrote:
>>>> This is the start of the stable review cycle for the 5.15.35 release.
>>>> There are 189 patches in this series, all will be posted as a response
>>>> to this one.  If anyone has any issues with these being applied, please
>>>> let me know.
>>>
>>> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn31/dcn31_hubbub.c: In function hubbub31_verify_allow_pstate_change_high':
>>> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn31/dcn31_hubbub.c:994:17: error: implicit declaration of function 'udelay' [-Werror=implicit-function-declaration]
>>>    994 |                 udelay(1);
>>>        |                 ^~~~~~
>>>
>>> Caused by "drm-amd-display-add-pstate-verification-and-recovery-for-dcn31.patch".
>>> Explicitly includng <linux/delay.h> in dcn31_hubbub.c fixes it.
>>>
>>> Current mainline version of dcn31_hubbub.c does not explicitly include
>>> <linux/delay.h>, so there seems to be some general inconsistency wrt.
>>> which dcn module includes what.
>>>
>>> CC'ing Nicholas Kazlauskas.
>>>
>> Should add: The problem is only seen with 32-bit (i386) builds.
> 
> I found this while building on my Zen2 Thinkpad, which is definitely 64 bits. :)
> 

Interesting. I see it with i386:allmodconfig and i386:allyesconfig.


Anyway, I suspect that commit 178fbb6d552f2 ("drm/amd/display:
Implement DPIA training loop") may "fix" the problem; it adds the include
of linux/delay.h to drivers/gpu/drm/amd/display/dc/os_types.h. I don't
think it would be appropriate to backport this patch to v5.15.y, though.

Guenter