[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <95a2e996285649dadba673f2f0614192@walle.cc>
Date: Mon, 18 Apr 2022 19:44:55 +0200
From: Michael Walle <michael@...le.cc>
To: Jean Delvare <jdelvare@...e.com>,
Guenter Roeck <linux@...ck-us.net>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>
Cc: linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/4] hwmon: add lan9668 driver
Hi,
Am 2022-04-01 23:40, schrieb Michael Walle:
> Add a temperature and fan controller driver for the Microchip LAN9668
> SoC.
>
> The temperature sensor uses a polynomial to calculate the actual
> temperature. Fortunately, the bt1-pvt already has such a calculation.
> It seems that the LAN9668 uses the same Analog Bits sensor as the
> BT1 although with a different characteristic. To be able to reuse the
> code move it to lib/ as it seems pretty generic to calculate any
> polynomial using integers only, which might also be used by other parts
> of the kernel. Another option might be to move the code to
> hwmon-poly.c,
> I'm not sure. Thoughts?
>
> I also plan on submitting patches to add temperature sensor support for
> the GPYxxx and LAN8814 PHYs which also use polynomial_calc().
>
> The last two patches adds the actual driver and the dt-binding for it.
>
> changes since v3:
> - validate input frequency in lan966x_hwmon_write_pwm_freq()
> - enable sensor before registering hwmon device
> - automatically disable sensor when driver is removed
> - set the required clock devider in case someone changed the
> hardware default before the driver is loaded
> - remove extra empty lines
>
> changes since v2:
> - strip unwanted copy pasta.. oops
> - use "select REGMAP" instead of "depends on"
>
> changes since v1:
> - add doc string to polynomial_calc(), moved the comment
> into the function.
> - add missing "select POLYNOMIAL" to the bt1_pvt driver
> Kconfig symbol
> - add hwmon driver documentation
> - cache sys_clk rate during probe
> - add missing ERR_CAST()
> - adapted comment for the PPS->RPM calculation
> - add temporary variable in lan966x_hwmon_read_pwm_freq()
>
> Michael Walle (4):
> lib: add generic polynomial calculation
> hwmon: (bt1-pvt) use generic polynomial functions
> dt-bindings: hwmon: add Microchip LAN966x bindings
> hwmon: add driver for the Microchip LAN966x SoC
Any news here? Or did I miss anything?
-michael
Powered by blists - more mailing lists