linux-kernel - Re: [PATCH] staging: media: av7110: comparison to NULL could be written "fe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.22.394.2204182018480.13551@hadrien>
Date:   Mon, 18 Apr 2022 20:22:16 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Aliya Rahmani <aliyarahmani786@...il.com>
cc:     mchehab@...nel.org, gregkh@...uxfoundation.org,
        linux-staging@...ts.linux.dev, outreachy@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: media: av7110: comparison to NULL could be
 written "fe_func"

On Mon, 18 Apr 2022, Aliya Rahmani wrote:

> Fixed coding style for null comparisons to be more
> consistent with the rest of the kernel coding style.

The log message (both the subject line and the text just above) should be
in the imperative.  Typically, that means that you should not be using
verbs that end in "ed".

There is too much detail in the subject line.  Consider how you could give
the general idea, but be more concise.

For the text above, what could you say rather than "fix".  When you say
that you fixed something, the reader may know (or at least hope) that it
is better, but gets no information about what you did, nor why.

julia

>
> Signed-off-by: Aliya Rahmani <aliyarahmani786@...il.com>
> ---
>  drivers/staging/media/av7110/av7110.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/av7110/av7110.c b/drivers/staging/media/av7110/av7110.c
> index d74ee0ecfb36..bdc6adf70d72 100644
> --- a/drivers/staging/media/av7110/av7110.c
> +++ b/drivers/staging/media/av7110/av7110.c
> @@ -107,7 +107,7 @@ static int av7110_num;
>
>  #define FE_FUNC_OVERRIDE(fe_func, av7110_copy, av7110_func) \
>  {\
> -	if (fe_func != NULL) { \
> +	if (fe_func) { \
>  		av7110_copy = fe_func; \
>  		fe_func = av7110_func; \
>  	} \
> --
> 2.25.1
>
>
>