[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20220418084538.ccvqhbik6a7ffz5j@ti.com>
Date: Mon, 18 Apr 2022 14:15:38 +0530
From: Pratyush Yadav <p.yadav@...com>
To: <Tudor.Ambarus@...rochip.com>
CC: <michael@...le.cc>, <miquel.raynal@...tlin.com>, <richard@....at>,
<vigneshr@...com>, <linux-mtd@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>, <Nicolas.Ferre@...rochip.com>
Subject: Re: [PATCH v3 3/3] mtd: spi-nor: Favor the BFPT-parsed
set_4byte_addr_mode method
On 14/04/22 09:32AM, Tudor.Ambarus@...rochip.com wrote:
> On 4/14/22 12:21, Michael Walle wrote:
> >> +static void macronix_nor_late_init(struct spi_nor *nor)
> >> +{
> >> + if (!nor->params->set_4byte_addr_mode)
> >> + nor->params->set_4byte_addr_mode =
> >> + spi_nor_set_4byte_addr_mode_en4b_ex4b;
> >
> > This is more of a general question. Can we have this in one
> > line? IMHO this looks awful and since linux nowadays relaxed the
> > 80 chars rule a bit and we have such long names.. I think it makes
> > sense to allow some lines to be longer than 80 chars.
>
> I still split my terminal in multiple windows and pretty much read
> code in a 80 chars limit. But I won't argue with you, it seems you
> care about it, so I'll change it.
FWIW, I do the same. I won't like it much if line lengths get too long.
I won't take any sides here though, either should be fine as long as the
result at least fits in 100 chars.
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
Powered by blists - more mailing lists