| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202204181725.iv9g9yFO-lkp@intel.com>
Date: Mon, 18 Apr 2022 17:22:05 +0800
From: kernel test robot <lkp@...el.com>
To: Yury Norov <yury.norov@...il.com>
Cc: kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [norov:bitmap 44/47] include/linux/bitmap.h:259:9: warning: 'memcpy'
forming offset [84, 87] is out of the bounds [0, 84] of object
'link_usettings' with type 'struct ethtool_link_usettings'
tree: https://github.com/norov/linux bitmap
head: 45a9e3feb171ccf077979b7ff6a0c6a732cfc17b
commit: 44fa42b086fd02ab7d41d92800b6888ee240fcdf [44/47] lib/bitmap: don't implement bitmap_(from,to)_arr32 on LE systems
config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20220418/202204181725.iv9g9yFO-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-19) 11.2.0
reproduce (this is a W=1 build):
# https://github.com/norov/linux/commit/44fa42b086fd02ab7d41d92800b6888ee240fcdf
git remote add norov https://github.com/norov/linux
git fetch --no-tags norov bitmap
git checkout 44fa42b086fd02ab7d41d92800b6888ee240fcdf
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash net/ethtool/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/cpumask.h:12,
from arch/x86/include/asm/cpumask.h:5,
from arch/x86/include/asm/msr.h:11,
from arch/x86/include/asm/processor.h:22,
from arch/x86/include/asm/timex.h:5,
from include/linux/timex.h:65,
from include/linux/time32.h:13,
from include/linux/time.h:60,
from include/linux/compat.h:10,
from net/ethtool/ioctl.c:10:
net/ethtool/ioctl.c: In function 'store_link_ksettings_for_user.constprop':
include/linux/bitmap.h:270:44: warning: array subscript 'long unsigned int[10]' is partly outside array bounds of 'struct ethtool_link_usettings[1]' [-Warray-bounds]
270 | dst[nbits / BITS_PER_LONG] &= BITMAP_LAST_WORD_MASK(nbits);
| ^~
net/ethtool/ioctl.c:516:39: note: while referencing 'link_usettings'
516 | struct ethtool_link_usettings link_usettings;
| ^~~~~~~~~~~~~~
In file included from include/linux/cpumask.h:12,
from arch/x86/include/asm/cpumask.h:5,
from arch/x86/include/asm/msr.h:11,
from arch/x86/include/asm/processor.h:22,
from arch/x86/include/asm/timex.h:5,
from include/linux/timex.h:65,
from include/linux/time32.h:13,
from include/linux/time.h:60,
from include/linux/compat.h:10,
from net/ethtool/ioctl.c:10:
include/linux/bitmap.h:270:44: warning: array subscript 'long unsigned int[10]' is partly outside array bounds of 'struct ethtool_link_usettings[1]' [-Warray-bounds]
270 | dst[nbits / BITS_PER_LONG] &= BITMAP_LAST_WORD_MASK(nbits);
| ^
net/ethtool/ioctl.c:516:39: note: while referencing 'link_usettings'
516 | struct ethtool_link_usettings link_usettings;
| ^~~~~~~~~~~~~~
In file included from include/linux/cpumask.h:12,
from arch/x86/include/asm/cpumask.h:5,
from arch/x86/include/asm/msr.h:11,
from arch/x86/include/asm/processor.h:22,
from arch/x86/include/asm/timex.h:5,
from include/linux/timex.h:65,
from include/linux/time32.h:13,
from include/linux/time.h:60,
from include/linux/compat.h:10,
from net/ethtool/ioctl.c:10:
In function 'bitmap_copy',
inlined from 'bitmap_copy_clear_tail' at include/linux/bitmap.h:268:2,
inlined from 'store_link_ksettings_for_user.constprop' at net/ethtool/ioctl.c:525:2:
>> include/linux/bitmap.h:259:9: warning: 'memcpy' forming offset [84, 87] is out of the bounds [0, 84] of object 'link_usettings' with type 'struct ethtool_link_usettings' [-Warray-bounds]
259 | memcpy(dst, src, len);
| ^~~~~~~~~~~~~~~~~~~~~
net/ethtool/ioctl.c: In function 'store_link_ksettings_for_user.constprop':
net/ethtool/ioctl.c:516:39: note: 'link_usettings' declared here
516 | struct ethtool_link_usettings link_usettings;
| ^~~~~~~~~~~~~~
In file included from include/linux/cpumask.h:12,
from arch/x86/include/asm/cpumask.h:5,
from arch/x86/include/asm/msr.h:11,
from arch/x86/include/asm/processor.h:22,
from arch/x86/include/asm/timex.h:5,
from include/linux/timex.h:65,
from include/linux/time32.h:13,
from include/linux/time.h:60,
from include/linux/compat.h:10,
from net/ethtool/ioctl.c:10:
In function 'bitmap_copy',
inlined from 'bitmap_copy_clear_tail' at include/linux/bitmap.h:268:2,
inlined from 'load_link_ksettings_from_user' at net/ethtool/ioctl.c:483:2:
>> include/linux/bitmap.h:259:9: warning: 'memcpy' forming offset [84, 87] is out of the bounds [0, 84] of object 'link_usettings' with type 'struct ethtool_link_usettings' [-Warray-bounds]
259 | memcpy(dst, src, len);
| ^~~~~~~~~~~~~~~~~~~~~
net/ethtool/ioctl.c: In function 'load_link_ksettings_from_user':
net/ethtool/ioctl.c:471:39: note: 'link_usettings' declared here
471 | struct ethtool_link_usettings link_usettings;
| ^~~~~~~~~~~~~~
vim +259 include/linux/bitmap.h
^1da177e4c3f41 Linus Torvalds 2005-04-16 254
^1da177e4c3f41 Linus Torvalds 2005-04-16 255 static inline void bitmap_copy(unsigned long *dst, const unsigned long *src,
8b4daad52fee77 Rasmus Villemoes 2015-02-12 256 unsigned int nbits)
^1da177e4c3f41 Linus Torvalds 2005-04-16 257 {
8b4daad52fee77 Rasmus Villemoes 2015-02-12 258 unsigned int len = BITS_TO_LONGS(nbits) * sizeof(unsigned long);
^1da177e4c3f41 Linus Torvalds 2005-04-16 @259 memcpy(dst, src, len);
^1da177e4c3f41 Linus Torvalds 2005-04-16 260 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 261
:::::: The code at line 259 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds@...970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@...970.osdl.org>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Powered by blists - more mailing lists