[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20220418093144.40859-1-hbh25y@gmail.com>
Date: Mon, 18 Apr 2022 17:31:44 +0800
From: Hangyu Hua <hbh25y@...il.com>
To: bjorn.andersson@...aro.org, mathieu.poirier@...aro.org,
arnaud.pouliquen@...s.st.com
Cc: linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org,
Hangyu Hua <hbh25y@...il.com>
Subject: [PATCH] rpmsg: virtio: fix possible double free in rpmsg_probe()
vch will be free in virtio_rpmsg_release_device() when
rpmsg_ns_register_device() fails. There is no need to call kfree() again.
Fix this by changing error path from free_vch to free_ctrldev.
Fixes: c486682ae1e2 ("rpmsg: virtio: Register the rpmsg_char device")
Signed-off-by: Hangyu Hua <hbh25y@...il.com>
---
drivers/rpmsg/virtio_rpmsg_bus.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c
index 3ede25b1f2e4..603233f0686e 100644
--- a/drivers/rpmsg/virtio_rpmsg_bus.c
+++ b/drivers/rpmsg/virtio_rpmsg_bus.c
@@ -973,7 +973,7 @@ static int rpmsg_probe(struct virtio_device *vdev)
err = rpmsg_ns_register_device(rpdev_ns);
if (err)
- goto free_vch;
+ goto free_ctrldev;
}
/*
@@ -997,8 +997,6 @@ static int rpmsg_probe(struct virtio_device *vdev)
return 0;
-free_vch:
- kfree(vch);
free_ctrldev:
rpmsg_virtio_del_ctrl_dev(rpdev_ctrl);
free_coherent:
--
2.25.1
Powered by blists - more mailing lists