linux-kernel - RE: [PATCH v2] uio: dfl: add HSSI feature id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR11MB38190E6EEF6DE3EB900290C585F39@DM6PR11MB3819.namprd11.prod.outlook.com>
Date:   Mon, 18 Apr 2022 01:32:18 +0000
From:   "Wu, Hao" <hao.wu@...el.com>
To:     "Zhang, Tianfei" <tianfei.zhang@...el.com>,
        "trix@...hat.com" <trix@...hat.com>,
        "mdf@...nel.org" <mdf@...nel.org>,
        "Xu, Yilun" <yilun.xu@...el.com>,
        "linux-fpga@...r.kernel.org" <linux-fpga@...r.kernel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Matthew Gerlach" <matthew.gerlach@...ux.intel.com>
Subject: RE: [PATCH v2] uio: dfl: add HSSI feature id



> -----Original Message-----
> From: Zhang, Tianfei <tianfei.zhang@...el.com>
> Sent: Tuesday, April 12, 2022 2:24 PM
> To: Wu, Hao <hao.wu@...el.com>; trix@...hat.com; mdf@...nel.org; Xu, Yilun
> <yilun.xu@...el.com>; linux-fpga@...r.kernel.org;
> gregkh@...uxfoundation.org
> Cc: linux-kernel@...r.kernel.org; Matthew Gerlach
> <matthew.gerlach@...ux.intel.com>; Zhang, Tianfei <tianfei.zhang@...el.com>
> Subject: [PATCH v2] uio: dfl: add HSSI feature id
> 
> From: Matthew Gerlach <matthew.gerlach@...ux.intel.com>
> 
> Add the feature id of the OFS HSSI (High Speed Serial Interface)

We still don't see any description on what OFS is here, or will OFS be added to
title as well? we don't expect another submission with the same title but for
XXX HSSI again.

> subsystem to table of ids supported by the uio_dfl driver. HSSI
> subsystem consists of harden/soft Ethernet MAC to support various
> ethernet usages and PCS/FEC/PMA direct modes for non-ethernet usages.
> 
> We leverage the uio_dfl driver to access the HSSI subsystem on user space,
> because the HSSI subsystem was designed for specific purposes and does
> not fit into the standard MAC and net kernel subsystems.
> 
> The Feature ID table of DFL can be found:
> https://github.com/OPAE/dfl-feature-id

Why you put it here? even this link there is no more descriptions to understand
what it is. Or can be removed here.

> 
> Signed-off-by: Matthew Gerlach <matthew.gerlach@...ux.intel.com>
> Signed-off-by: Tianfei Zhang <tianfei.zhang@...el.com>
> ---
> v2: add HSSI introduction and the git repo of Feature ID table.
> ---
>  drivers/uio/uio_dfl.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c
> index 89c0fc7b0cbc..660e1d0bf6b9 100644
> --- a/drivers/uio/uio_dfl.c
> +++ b/drivers/uio/uio_dfl.c
> @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device *ddev)
>  }
> 
>  #define FME_FEATURE_ID_ETH_GROUP	0x10
> +#define FME_FEATURE_ID_OFS_HSSI		0x15
> 
>  static const struct dfl_device_id uio_dfl_ids[] = {
>  	{ FME_ID, FME_FEATURE_ID_ETH_GROUP },
> +	{ FME_ID, FME_FEATURE_ID_OFS_HSSI },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(dfl, uio_dfl_ids);
> --
> 2.26.2