[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1e3ede4e-994b-4d87-b907-ec68661fb958@linaro.org>
Date: Mon, 18 Apr 2022 13:43:29 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Andrew Lunn <andrew@...n.ch>,
Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc: ulf.hansson@...aro.org, robh+dt@...nel.org, krzk+dt@...nel.org,
gregory.clement@...tlin.com, sebastian.hesselbarth@...il.com,
linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 4/4] dt-bindings: mmc: convert sdhci-dove to JSON schema
On 15/04/2022 01:33, Andrew Lunn wrote:
> Hi Chris
>
>> +required:
>> + - compatible
>> + - reg
>> + - interrupts
>
> https://elixir.bootlin.com/linux/latest/source/drivers/mmc/host/sdhci-dove.c#L78
>
> https://elixir.bootlin.com/linux/latest/source/arch/arm/boot/dts/dove.dtsi#L344
>
> Dove does actually have a clock. It looks like it is optional in the
> driver, but the .dtsi file has it. It is not documented in the current
> .txt file, so i can understand you missing it.
>
> I'm surprised the DT tools didn't complain about an unexpected
> property.
They did. :)
It seems binding is a bit out of date, so Chris should extend/update it.
Same comments about maintainer as for patch #3.
Best regards,
Krzysztof
Powered by blists - more mailing lists