[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <fb275639-096e-78c2-3cbb-1bb10f4bbb08@linaro.org>
Date: Mon, 18 Apr 2022 13:49:25 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Fabien Parent <fparent@...libre.com>,
Alim Akhtar <alim.akhtar@...sung.com>,
Avri Altman <avri.altman@....com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Matthias Brugger <matthias.bgg@...il.com>,
Stanley Chu <stanley.chu@...iatek.com>
Cc: linux-scsi@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: ufs: mediatek,ufs: add compatible for
MT8195 SoC
On 15/04/2022 18:59, Fabien Parent wrote:
> Add bindings for the MT8195 UFS support.
>
> The MT8195 SoC requires more clocks to be enabled compared to MT8183 and
> MT8192. Document the clocks required for MT8195.
>
> Signed-off-by: Fabien Parent <fparent@...libre.com>
> ---
> .../devicetree/bindings/ufs/mediatek,ufs.yaml | 27 ++++++++++++++-----
> 1 file changed, 21 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
> index 32fd535a514a..5ed36e95e933 100644
> --- a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
> +++ b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
> @@ -14,16 +14,31 @@ allOf:
>
> properties:
> compatible:
> - enum:
> - - mediatek,mt8183-ufshci
> - - mediatek,mt8192-ufshci
> + oneOf:
> + - enum:
> + - mediatek,mt8183-ufshci
> + - mediatek,mt8192-ufshci
> + - items:
> + - const: mediatek,mt8195-ufshci
> + - const: mediatek,mt8183-ufshci
Are you sure that these devices are compatible? Amount of clock
differences suggests that not (or original bindings were not complete).
>
> clocks:
> - maxItems: 1
> + minItems: 1
> + maxItems: 8
>
> clock-names:
> - items:
> - - const: ufs
> + oneOf:
> + - items:
> + - const: ufs
> + - items:
> + - const: ufs
> + - const: ufs_aes
> + - const: ufs_tick
> + - const: unipro_sysclk
> + - const: unipro_tick
> + - const: unipro_mp_bclk
> + - const: ufs_tx_symbol
> + - const: ufs_mem_sub
Add allOf:if:then: which specifies these clocks per different compatible.
Best regards,
Krzysztof
Powered by blists - more mailing lists