linux-kernel - Re: [PATCH 3/3] staging: media: zoran: avoid macro argument precedence issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.22.394.2204181408230.11986@hadrien>
Date:   Mon, 18 Apr 2022 14:09:37 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Aliya Rahmani <aliyarahmani786@...il.com>
cc:     clabbe@...libre.com, gregkh@...uxfoundation.org,
        linux-staging@...ts.linux.dev, outreachy@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] staging: media: zoran: avoid macro argument precedence
 issues



On Mon, 18 Apr 2022, Aliya Rahmani wrote:

> This patch fixes checkpatch warnings of precedence issues. Added parentheses
> around macro argument 'num'.

You should use the imperative.  This "Add" rather than "Added".

The subject line would be better as "add parentheses on macro parameter".
That describes what you did, rather than what you avoided (avoided how?).

julia

>
> Signed-off-by: Aliya Rahmani <aliyarahmani786@...il.com>
> ---
>  drivers/staging/media/zoran/videocodec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/zoran/videocodec.c b/drivers/staging/media/zoran/videocodec.c
> index 19732a47c8bd..925f90fd5885 100644
> --- a/drivers/staging/media/zoran/videocodec.c
> +++ b/drivers/staging/media/zoran/videocodec.c
> @@ -22,7 +22,7 @@ MODULE_PARM_DESC(videocodec_debug, "Debug level (0-4)");
>
>  #define dprintk(num, format, args...) \
>  	do { \
> -		if (videocodec_debug >= num) \
> +		if (videocodec_debug >= (num)) \
>  			printk(format, ##args); \
>  	} while (0)
>
> --
> 2.25.1
>
>
>