[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d441a648-a85c-6610-fc07-0956395f903d@linaro.org>
Date: Mon, 18 Apr 2022 14:24:19 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Samuel Holland <samuel@...lland.org>,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
linux-input@...r.kernel.org
Cc: devicetree@...r.kernel.org,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Rob Herring <robh+dt@...nel.org>, Ondrej Jirman <x@....cz>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: input: Add the PinePhone keyboard
binding
On 17/04/2022 04:16, Samuel Holland wrote:
(...)
> +properties:
> + compatible:
> + const: pine64,pinephone-keyboard
> +
> + reg:
> + const: 0x15
> +
> + interrupts:
> + maxItems: 1
> +
> + vbat-supply:
> + description: Supply for the keyboard MCU
> +
> + wakeup-source: true
> +
> + i2c-bus:
Generic node names, so just "i2c".
> + $ref: /schemas/i2c/i2c-controller.yaml#
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +unevaluatedProperties: false
You do not include any other schema at this level, so this should be
additionalProperties:false.
> +
> +examples:
> + - |
> + #include <dt-bindings/input/input.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + keyboard@15 {
> + compatible = "pine64,pinephone-keyboard";
> + reg = <0x15>;
> + interrupt-parent = <&r_pio>;
> + interrupts = <0 12 IRQ_TYPE_EDGE_FALLING>; /* PL12 */
> +
> + i2c-bus {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + charger@75 {
> + reg = <0x75>;
> + };
> + };
> + };
> + };
Best regards,
Krzysztof
Powered by blists - more mailing lists