[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <8ac63b04e66de3b1fb1a1ef4547982a345e24ed0.camel@mediatek.com>
Date: Mon, 18 Apr 2022 11:57:59 +0800
From: Jason-JH Lin <jason-jh.lin@...iatek.com>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
"Rob Herring" <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Matthias Brugger <matthias.bgg@...il.com>,
Chun-Kuang Hu <chunkuang.hu@...nel.org>
CC: CK Hu <ck.hu@...iatek.com>, Nancy Lin <nancy.lin@...iatek.com>,
"Singo Chang" <singo.chang@...iatek.com>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<dri-devel@...ts.freedesktop.org>,
<linux-mediatek@...ts.infradead.org>,
<linux-arm-kernel@...ts.infradead.org>,
<Project_Global_Chrome_Upstream_Group@...iatek.com>
Subject: Re: [PATCH v19 10/10] soc: mediatek: remove DDP_DOMPONENT_DITHER
enum
Hi Angelo,
Thanks for the reviews.
On Fri, 2022-04-15 at 12:32 +0200, AngeloGioacchino Del Regno wrote:
> Il 15/04/22 10:39, jason-jh.lin ha scritto:
> > After mmsys and drm change DITHER enum to DDP_COMPONENT_DITHER0,
> > mmsys header can remove the useless DDP_COMPONENT_DITHER enum.
> >
> > Signed-off-by: jason-jh.lin <jason-jh.lin@...iatek.com>
>
> Can you please fix the commit title with:
> soc: mediatek: remove DDP_DOMPONENT_DITHER from enum
>
> that "from" is important, as you're not removing *an enum*, but *from
> an enum*.
>
Yes, I agree with you.
I'll fix it in the next version.
Thanks.
Regards,
Jason-JH.Lin
> After that:
>
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@...labora.com>
>
> Thanks!
> Angelo
--
Jason-JH Lin <jason-jh.lin@...iatek.com>
Powered by blists - more mailing lists