linux-kernel - Re: [PATCH v2] staging: vchiq_arm: change vchiq_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yl7FC9M0hz7kQM4j@kroah.com>
Date:   Tue, 19 Apr 2022 16:19:55 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Tom Rix <trix@...hat.com>
Cc:     nsaenz@...nel.org, bcm-kernel-feedback-list@...adcom.com,
        stefan.wahren@...e.com, gascoar@...il.com, ojaswin98@...il.com,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: vchiq_arm: change vchiq_platform_init from
 global to static

On Tue, Apr 19, 2022 at 09:36:16AM -0400, Tom Rix wrote:
> Smatch reports this issue
> vchiq_arm.c:466:5: warning: symbol 'vchiq_platform_init' was not declared. Should it be static?
> 
> vchiq_platform_init is only used in vchiq_arm.c.  Single file variables should
> not be global so change vchiq_platform_init's storage-class specifier to static.

You did not change a variable, you changed a function type.

> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
> v2: refomat commit log

Why did you not fix the build breakage?

{sigh}