| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Apr 2022 23:23:44 +0800
From: kernel test robot <lkp@...el.com>
To: Russ Weight <russell.h.weight@...el.com>, mcgrof@...nel.org,
rafael@...nel.org, linux-kernel@...r.kernel.org
Cc: kbuild-all@...ts.01.org, trix@...hat.com, lgoncalv@...hat.com,
yilun.xu@...el.com, hao.wu@...el.com,
matthew.gerlach@...ux.intel.com,
basheer.ahmed.muddebihal@...el.com, tianfei.zhang@...el.com,
Russ Weight <russell.h.weight@...el.com>
Subject: Re: [PATCH v3 4/8] firmware_loader: Add firmware-upload support
Hi Russ,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on driver-core/driver-core-testing]
[also build test ERROR on shuah-kselftest/next mcgrof/sysctl-next linus/master v5.18-rc3 next-20220419]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Russ-Weight/Extend-FW-framework-for-user-FW-uploads/20220419-064126
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git 3123109284176b1532874591f7c81f3837bbdc17
config: parisc-randconfig-r033-20220419 (https://download.01.org/0day-ci/archive/20220419/202204192359.CTXNmgvX-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/827b02dbc9848fee497e3f3edbe6ff441cae32f6
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Russ-Weight/Extend-FW-framework-for-user-FW-uploads/20220419-064126
git checkout 827b02dbc9848fee497e3f3edbe6ff441cae32f6
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross W=1 O=build_dir ARCH=parisc SHELL=/bin/bash drivers/base/firmware_loader/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
In file included from drivers/base/firmware_loader/sysfs.c:9:
drivers/base/firmware_loader/sysfs.h: In function '__firmware_loading_timeout':
drivers/base/firmware_loader/sysfs.h:78:34: error: invalid use of undefined type 'struct firmware_fallback_config'
78 | return fw_fallback_config.loading_timeout;
| ^
drivers/base/firmware_loader/sysfs.h: In function '__fw_fallback_set_timeout':
drivers/base/firmware_loader/sysfs.h:84:27: error: invalid use of undefined type 'struct firmware_fallback_config'
84 | fw_fallback_config.loading_timeout = timeout;
| ^
drivers/base/firmware_loader/sysfs.c: At top level:
>> drivers/base/firmware_loader/sysfs.c:113:5: error: redefinition of 'register_sysfs_loader'
113 | int register_sysfs_loader(void)
| ^~~~~~~~~~~~~~~~~~~~~
In file included from drivers/base/firmware_loader/sysfs.c:9:
drivers/base/firmware_loader/sysfs.h:52:19: note: previous definition of 'register_sysfs_loader' with type 'int(void)'
52 | static inline int register_sysfs_loader(void)
| ^~~~~~~~~~~~~~~~~~~~~
drivers/base/firmware_loader/sysfs.c: In function 'register_sysfs_loader':
>> drivers/base/firmware_loader/sysfs.c:119:16: error: implicit declaration of function 'register_firmware_config_sysctl' [-Werror=implicit-function-declaration]
119 | return register_firmware_config_sysctl();
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/base/firmware_loader/sysfs.c: At top level:
>> drivers/base/firmware_loader/sysfs.c:122:6: error: redefinition of 'unregister_sysfs_loader'
122 | void unregister_sysfs_loader(void)
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/base/firmware_loader/sysfs.c:9:
drivers/base/firmware_loader/sysfs.h:57:20: note: previous definition of 'unregister_sysfs_loader' with type 'void(void)'
57 | static inline void unregister_sysfs_loader(void)
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/base/firmware_loader/sysfs.c: In function 'unregister_sysfs_loader':
>> drivers/base/firmware_loader/sysfs.c:124:9: error: implicit declaration of function 'unregister_firmware_config_sysctl' [-Werror=implicit-function-declaration]
124 | unregister_firmware_config_sysctl();
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/base/firmware_loader/sysfs.c:9:
drivers/base/firmware_loader/sysfs.h: In function '__firmware_loading_timeout':
drivers/base/firmware_loader/sysfs.h:79:1: error: control reaches end of non-void function [-Werror=return-type]
79 | }
| ^
cc1: some warnings being treated as errors
vim +/register_sysfs_loader +113 drivers/base/firmware_loader/sysfs.c
7fb618c8a43c63 Russ Weight 2022-04-18 112
7fb618c8a43c63 Russ Weight 2022-04-18 @113 int register_sysfs_loader(void)
7fb618c8a43c63 Russ Weight 2022-04-18 114 {
7fb618c8a43c63 Russ Weight 2022-04-18 115 int ret = class_register(&firmware_class);
7fb618c8a43c63 Russ Weight 2022-04-18 116
7fb618c8a43c63 Russ Weight 2022-04-18 117 if (ret != 0)
7fb618c8a43c63 Russ Weight 2022-04-18 118 return ret;
7fb618c8a43c63 Russ Weight 2022-04-18 @119 return register_firmware_config_sysctl();
7fb618c8a43c63 Russ Weight 2022-04-18 120 }
7fb618c8a43c63 Russ Weight 2022-04-18 121
7fb618c8a43c63 Russ Weight 2022-04-18 @122 void unregister_sysfs_loader(void)
7fb618c8a43c63 Russ Weight 2022-04-18 123 {
7fb618c8a43c63 Russ Weight 2022-04-18 @124 unregister_firmware_config_sysctl();
7fb618c8a43c63 Russ Weight 2022-04-18 125 class_unregister(&firmware_class);
7fb618c8a43c63 Russ Weight 2022-04-18 126 }
7fb618c8a43c63 Russ Weight 2022-04-18 127
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Powered by blists - more mailing lists