linux-kernel - Re: [PATCH] ntb_perf: fix doubletest cocci warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d8240552-acea-0214-a5a3-6bf07ad6b007@intel.com>
Date:   Tue, 19 Apr 2022 08:37:28 -0700
From:   Dave Jiang <dave.jiang@...el.com>
To:     Guo Zhengkui <guozhengkui@...o.com>, Jon Mason <jdmason@...zu.us>,
        Allen Hubbe <allenbh@...il.com>,
        Yang Li <yang.lee@...ux.alibaba.com>,
        Alexander Fomichev <fomichev.ru@...il.com>,
        Serge Semin <fancer.lancer@...il.com>,
        "open list:NTB DRIVER CORE" <ntb@...ts.linux.dev>,
        open list <linux-kernel@...r.kernel.org>
Cc:     zhengkui_guo@...look.com
Subject: Re: [PATCH] ntb_perf: fix doubletest cocci warning


On 4/19/2022 12:18 AM, Guo Zhengkui wrote:
> `!data->ops.init` has been repeated triple. The original logic is to
> check whether `.init`, `.run` and `.clear` callbacks are NULL or not.
>
> Signed-off-by: Guo Zhengkui <guozhengkui@...o.com>

Reviewed-by: Dave Jiang <dave.jiang@...el.com>


> ---
>   drivers/ntb/test/ntb_perf.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c
> index c106c3a5097e..dcae4be91365 100644
> --- a/drivers/ntb/test/ntb_perf.c
> +++ b/drivers/ntb/test/ntb_perf.c
> @@ -1451,7 +1451,7 @@ static void perf_ext_lat_work(struct work_struct *work)
>   {
>   	struct perf_ext_lat_data *data = to_ext_lat_data(work);
>   
> -	if (!data->ops.init || !data->ops.init || !data->ops.init) {
> +	if (!data->ops.init || !data->ops.run || !data->ops.clear) {
>   		struct perf_ctx *perf = data->perf;
>   
>   		data->status = -EFAULT;