linux-kernel - Re: [PATCH 1/3] SPI: Ingenic: Add support for use GPIO as chip select line.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yl7quUXmEEPHfTfC@sirena.org.uk>
Date:   Tue, 19 Apr 2022 18:00:41 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Paul Cercueil <paul@...pouillou.net>
Cc:     Zhou Yanjie <zhouyanjie@...yeetech.com>, robh+dt@...nel.org,
        krzk+dt@...nel.org, linux-spi@...r.kernel.org,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, contact@...ur-rojek.eu,
        dongsheng.qiu@...enic.com, aric.pzqi@...enic.com,
        rick.tyliu@...enic.com, sernia.zhou@...mail.com,
        zhenwenjin@...il.com, reimu@...omaker.com
Subject: Re: [PATCH 1/3] SPI: Ingenic: Add support for use GPIO as chip
 select line.

On Sat, Apr 16, 2022 at 05:36:46PM +0100, Paul Cercueil wrote:
> Le sam., avril 16 2022 at 19:55:13 +0800, Zhou Yanjie
> > On 2022/4/15 下午11:00, Paul Cercueil wrote:

> > > > -    ctlr->num_chipselect = 2;
> > > > +    ctlr->use_gpio_descriptors = true;

> > > I wonder if this should be set conditionally instead. Maybe set it
> > > to "true" if the "num-cs" property exists?

> > I'm not too sure, but it seems some other drivers like "spi-sun6i.c",
> > "spi-stm32.c", "spi-s3c64xx.c", "spi-pic32.c", etc. set it
> > unconditionally.

> Ok, maybe Mark can enlighten us here.

use_gpio_descriptions is just selecting which version of the GPIO APIs
we should use if we're handling GPIOs rather than if we should handle
them.  We've got one last driver using the numerical GPIO APIs, once
that one is converted we should just be able to drop the flag since
everything will be using descriptors.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)