linux-kernel - Re: [PATCH v2 3/9] clk: qcom: msm8996-cpu: Add MSM8996 Pro CBF support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <sld5QpXz-AMurBB0RoYLgMHsEcUsgubB_V3YQO8HP8vFxjd7RwALrHFYBJSiv09SMsXuy4nnWDy2ZQ8IRlEnTl1zXb4EXqPT19y_n-GMd9Q=@protonmail.com>
Date:   Tue, 19 Apr 2022 17:55:33 +0000
From:   Yassine Oudjana <y.oudjana@...tonmail.com>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Andy Gross <agross@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Ilia Lin <ilia.lin@...nel.org>,
        Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Loic Poulain <loic.poulain@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH v2 3/9] clk: qcom: msm8996-cpu: Add MSM8996 Pro CBF support

On Tuesday, April 19th, 2022 at 9:49 PM, Bjorn Andersson <bjorn.andersson@...aro.org> wrote:
> On Fri 08 Apr 23:16 CDT 2022, Yassine Oudjana wrote:
>
> > MSM8996 Pro (MSM8996SG) has a /4 divisor on the CBF clock
> > instead of /2. This allows it to reach a lower minimum frequency
> > of 192000000Hz compared to 307200000Hz on regular MSM8996.
> > Add support for setting the CBF clock divisor to /4 for MSM8996 Pro.
> >
> > Signed-off-by: Yassine Oudjana y.oudjana@...tonmail.com
> > Reviewed-by: Konrad Dybcio konrad.dybcio@...ainline.org
> > ---
> > drivers/clk/qcom/clk-cpu-8996.c | 61 +++++++++++++++++++++------------
> > 1 file changed, 40 insertions(+), 21 deletions(-)
> >
> > diff --git a/drivers/clk/qcom/clk-cpu-8996.c b/drivers/clk/qcom/clk-cpu-8996.c
> > index 8afc271f92d0..231d8224fa16 100644
> > --- a/drivers/clk/qcom/clk-cpu-8996.c
> > +++ b/drivers/clk/qcom/clk-cpu-8996.c
> > @@ -70,11 +70,11 @@ enum _pmux_input {
> >
> > enum {
> > CBF_PLL_INDEX = 1,
> > - CBF_DIV_2_INDEX,
> > + CBF_DIV_INDEX,
> > CBF_SAFE_INDEX
> > };
>
>
> I don't have this enum in my tree. Could you please double check that
> this works on linux-next?

It's added in a patch[1] that isn't applied yet. The patch is mentioned
in the cover letter, which you had trouble finding unfortunately.

> And can you please send the next revision using git send-email with a
> cover-letter, so that the patches are related in my inbox.

Sorry about that. I've already resent the series properly. You should
find [PATCH RESEND v2 */9] in your inbox, otherwise here[2] is a link.

[1] https://lore.kernel.org/linux-arm-msm/20210528192541.1120703-1-konrad.dybcio@somainline.org/
[2] https://lore.kernel.org/linux-arm-msm/20220416025637.83484-1-y.oudjana@protonmail.com/T/#t