linux-kernel - Re: [PATCH v2] gpiolib: of: fix bounds check for 'gpio-reserved-ranges'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYYA1CtSz_w8aioBC7FLgkEjO_Wk_XuL-LwLmpCouNfeQ@mail.gmail.com>
Date:   Tue, 19 Apr 2022 23:53:38 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Andrei Lalaev <andrei.lalaev@...id.com>
Cc:     brgl@...ev.pl, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, andy.shevchenko@...il.com
Subject: Re: [PATCH v2] gpiolib: of: fix bounds check for 'gpio-reserved-ranges'

On Fri, Apr 15, 2022 at 9:09 AM Andrei Lalaev <andrei.lalaev@...id.com> wrote:

> Gpiolib interprets the elements of "gpio-reserved-ranges" as "start,size"
> because it clears "size" bits starting from the "start" bit in the according
> bitmap. So it has to use "greater" instead of "greater or equal" when performs
> bounds check to make sure that GPIOs are in the available range.
> Previous implementation skipped ranges that include the last GPIO in
> the range.
>
> Fixes: 726cb3ba4969 ("gpiolib: Support 'gpio-reserved-ranges' property")
> Signed-off-by: Andrei Lalaev <andrei.lalaev@...id.com>

Nice patch!

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij