linux-kernel - Re: [PATCH 2/3] LoadPin: Enable loading from trusted dm-verity devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202204191222.n0HWtNe0-lkp@intel.com>
Date:   Tue, 19 Apr 2022 12:32:43 +0800
From:   kernel test robot <lkp@...el.com>
To:     Matthias Kaehlcke <mka@...omium.org>,
        Alasdair Kergon <agk@...hat.com>,
        Mike Snitzer <snitzer@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        James Morris <jmorris@...ei.org>,
        "Serge E . Hallyn" <serge@...lyn.com>
Cc:     kbuild-all@...ts.01.org, linux-raid@...r.kernel.org,
        linux-kernel@...r.kernel.org, Song Liu <song@...nel.org>,
        linux-security-module@...r.kernel.org,
        Douglas Anderson <dianders@...omium.org>, dm-devel@...hat.com,
        Matthias Kaehlcke <mka@...omium.org>
Subject: Re: [PATCH 2/3] LoadPin: Enable loading from trusted dm-verity
 devices

Hi Matthias,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on device-mapper-dm/for-next]
[also build test ERROR on song-md/md-next kees/for-next/pstore v5.18-rc3 next-20220414]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Matthias-Kaehlcke/LoadPin-Enable-loading-from-trusted-dm-verity-devices/20220419-051810
base:   https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next
config: powerpc-buildonly-randconfig-r002-20220417 (https://download.01.org/0day-ci/archive/20220419/202204191222.n0HWtNe0-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/5af892969b227a2602732e4be44a0c4a41967400
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Matthias-Kaehlcke/LoadPin-Enable-loading-from-trusted-dm-verity-devices/20220419-051810
        git checkout 5af892969b227a2602732e4be44a0c4a41967400
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash security/loadpin/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   security/loadpin/loadpin.c: In function 'loadpin_init':
>> security/loadpin/loadpin.c:404:44: error: 'loadpin_sysctl_path' undeclared (first use in this function)
     404 |                 if (!register_sysctl_paths(loadpin_sysctl_path,
         |                                            ^~~~~~~~~~~~~~~~~~~
   security/loadpin/loadpin.c:404:44: note: each undeclared identifier is reported only once for each function it appears in
>> security/loadpin/loadpin.c:405:44: error: 'loadpin_sysctl_table_verity' undeclared (first use in this function)
     405 |                                            loadpin_sysctl_table_verity))
         |                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/loadpin_sysctl_path +404 security/loadpin/loadpin.c

   395	
   396	static int __init loadpin_init(void)
   397	{
   398		pr_info("ready to pin (currently %senforcing)\n",
   399			enforce ? "" : "not ");
   400		parse_exclude();
   401		security_add_hooks(loadpin_hooks, ARRAY_SIZE(loadpin_hooks), "loadpin");
   402	
   403		if (IS_ENABLED(CONFIG_SECURITY_LOADPIN_VERITY)) {
 > 404			if (!register_sysctl_paths(loadpin_sysctl_path,
 > 405						   loadpin_sysctl_table_verity))
   406				pr_notice("sysctl registration failed!\n");
   407		}
   408	
   409		return 0;
   410	}
   411	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp