linux-kernel - RE: [PATCH v4 0/2] Introduce Intra-refresh type control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR02MB5148F8DD51F2E69B6C739231F3F29@DM6PR02MB5148.namprd02.prod.outlook.com>
Date:   Tue, 19 Apr 2022 05:08:10 +0000
From:   "Dikshita Agarwal (QUIC)" <quic_dikshita@...cinc.com>
To:     "stanimir.varbanov@...aro.org" <stanimir.varbanov@...aro.org>,
        "Dikshita Agarwal (QUIC)" <quic_dikshita@...cinc.com>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>
CC:     "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
        "ezequiel@...labora.com" <ezequiel@...labora.com>,
        "stanimir.varbanov@...aro.org" <stanimir.varbanov@...aro.org>,
        "Vikash Garodia (QUIC)" <quic_vgarodia@...cinc.com>,
        "Maheshwar Ajja (QUIC)" <quic_majja@...cinc.com>,
        quic_jdas <quic_jdas@...cinc.com>
Subject: RE: [PATCH v4 0/2] Introduce Intra-refresh type control

Hi Stan,

I was waiting for your comments on Venus changes if any, so that I can address all comments together in next patch.
Posted a new patchset v5 now, pls review.

Thanks,
Dikshita Agarwal

-----Original Message-----
From: Stanimir Varbanov <stanimir.varbanov@...aro.org> 
Sent: Thursday, April 07, 2022 1:53 AM
To: Dikshita Agarwal (QUIC) <quic_dikshita@...cinc.com>; linux-media@...r.kernel.org; linux-kernel@...r.kernel.org; hverkuil-cisco@...all.nl
Cc: linux-arm-msm@...r.kernel.org; ezequiel@...labora.com; stanimir.varbanov@...aro.org; quic_vgarodia@...cinc.com; Maheshwar Ajja (QUIC) <quic_majja@...cinc.com>; quic_jdas <quic_jdas@...cinc.com>
Subject: Re: [PATCH v4 0/2] Introduce Intra-refresh type control

Dikshita,

I cannot find new version of this patchset with Han's comments addressed?

On 3/14/22 12:09, quic_dikshita@...cinc.com wrote:
> From: Dikshita Agarwal <quic_dikshita@...cinc.com>
> 
> Hi,
> 
> This series add a new intra-refresh type control for encoders.
> this can be used to specify which intra refresh to be enabled, random, cyclic or none.
> 
> Change since v0:
>  Dropped INTRA_REFRESH_TYPE_NONE as it was not needed.
>  Intra refresh period value as zero will disable the intra  refresh.
> 
> Change since v1:
>  Updated the control name for better undestanding.
>  Also updated the documentation accordingly.
> 
> Change since v2:
>  Updated the venus driver implementation as well to use the  correct control name. Missed in v2.
> 
> Change since v3:
>  Addressed comments from Hans in v4l2 patch.
>  Enabled the support for cyclic intra refresh in venus driver.
> 
> Thanks,
> Dikshita
> 
> Dikshita Agarwal (2):
>   media: v4l2-ctrls: Add intra-refresh type control
>   venus: venc: Add support for intra-refresh mode
> 
>  .../userspace-api/media/v4l/ext-ctrls-codec.rst    | 22 ++++++++++++++++++++++
>  drivers/media/platform/qcom/venus/core.h           |  1 +
>  drivers/media/platform/qcom/venus/venc.c           |  6 +++++-
>  drivers/media/platform/qcom/venus/venc_ctrls.c     | 10 ++++++++++
>  drivers/media/v4l2-core/v4l2-ctrls-defs.c          |  9 +++++++++
>  include/uapi/linux/v4l2-controls.h                 |  5 +++++
>  6 files changed, 52 insertions(+), 1 deletion(-)
> 

-- 
regards,
Stan