linux-kernel - Re: 5.17.0 boot issue on Miata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yl5AXvU+cBH5ex4K@gherkin.frus.com>
Date:   Mon, 18 Apr 2022 23:53:50 -0500
From:   Bob Tracy <rct@...s.com>
To:     debian-alpha@...ts.debian.org
Cc:     Michael Cree <mcree@...on.net.nz>, linux-alpha@...r.kernel.org,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: 5.17.0 boot issue on Miata

(Adding linux-scsi and linux-kernel, now that bisection is complete.)

On Wed, Apr 06, 2022 at 05:44:01PM -0500, Bob Tracy wrote:
> v5.17-rc2 ok.  v5.17-rc3 I get the disk sector errors and hang that I
> reported in the first message in this thread.

This is on an Alpha Miata platform (PWS 433au) with QLogic ISP1020 controller.

Here's the implicated commit:

edb854a3680bacc9ef9b91ec0c5ff6105886f6f3 is the first bad commit
commit edb854a3680bacc9ef9b91ec0c5ff6105886f6f3
Author: Ming Lei <ming.lei@...hat.com>
Date:   Thu Jan 27 23:37:33 2022 +0800

    scsi: core: Reallocate device's budget map on queue depth change
    
    We currently use ->cmd_per_lun as initial queue depth for setting up the
    budget_map. Martin Wilck reported that it is common for the queue_depth to
    be subsequently updated in slave_configure() based on detected hardware
    characteristics.
    
    As a result, for some drivers, the static host template settings for
    cmd_per_lun and can_queue won't actually get used in practice. And if the
    default values are used to allocate the budget_map, memory may be consumed
    unnecessarily.
    
    Fix the issue by reallocating the budget_map after ->slave_configure()
    returns. At that time the device queue_depth should accurately reflect what
    the hardware needs.
    
    Link: https://lore.kernel.org/r/20220127153733.409132-1-ming.lei@redhat.com
    Cc: Bart Van Assche <bvanassche@....org>
    Reported-by: Martin Wilck <martin.wilck@...e.com>
    Suggested-by: Martin Wilck <martin.wilck@...e.com>
    Tested-by: Martin Wilck <mwilck@...e.com>
    Reviewed-by: Martin Wilck <mwilck@...e.com>
    Reviewed-by: Bart Van Assche <bvanassche@....org>
    Signed-off-by: Ming Lei <ming.lei@...hat.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@...cle.com>

 drivers/scsi/scsi_scan.c | 55 +++++++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 50 insertions(+), 5 deletions(-)

 Respectfully,
 --Bob